Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm

Issue 2707963002: [ObjC ARC] Converts ios/chrome/browser/ui/omnibox:omnibox_internal to ARC. (Closed)
Patch Set: weaks Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm
diff --git a/ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm b/ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm
index 3196ae46d7e506a5e86867ed79bd9de53bb63bde..249e447d5d278fee828ad5c356e8e822c75ac4b8 100644
--- a/ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm
+++ b/ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm
@@ -5,13 +5,17 @@
#import "ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.h"
#include "base/logging.h"
-#include "base/mac/objc_property_releaser.h"
+
#import "ios/chrome/browser/ui/omnibox/truncating_attributed_label.h"
#include "ios/chrome/browser/ui/rtl_geometry.h"
#include "ios/chrome/browser/ui/ui_util.h"
#import "ios/chrome/browser/ui/uikit_ui_util.h"
#include "ios/chrome/grit/ios_theme_resources.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
namespace {
const CGFloat kImageDimensionLength = 19.0;
const CGFloat kLeadingPaddingIpad = 164;
@@ -22,7 +26,6 @@ const CGFloat kAppendButtonSize = 48.0;
@interface OmniboxPopupMaterialRow () {
BOOL _incognito;
- base::mac::ObjCPropertyReleaser _propertyReleaser_OmniboxPopupMaterialRow;
}
// Set the append button normal and highlighted images.
@@ -51,8 +54,6 @@ const CGFloat kAppendButtonSize = 48.0;
self.isAccessibilityElement = YES;
self.backgroundColor = [UIColor clearColor];
_incognito = incognito;
- _propertyReleaser_OmniboxPopupMaterialRow.Init(
- self, [OmniboxPopupMaterialRow class]);
_textTruncatingLabel =
[[OmniboxPopupTruncatingLabel alloc] initWithFrame:CGRectZero];
@@ -66,7 +67,7 @@ const CGFloat kAppendButtonSize = 48.0;
_detailTruncatingLabel.userInteractionEnabled = NO;
[self addSubview:_detailTruncatingLabel];
- _appendButton = [[UIButton buttonWithType:UIButtonTypeCustom] retain];
+ _appendButton = [UIButton buttonWithType:UIButtonTypeCustom];
[_appendButton setContentMode:UIViewContentModeRight];
[self updateAppendButtonImages];
// TODO(justincohen): Consider using the UITableViewCell's accessory view.

Powered by Google App Engine
This is Rietveld 408576698