[ObjC ARC] Converts ios/chrome/browser/ui/omnibox:omnibox_internal to ARC.

ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.h"
 
 #include <memory>
 
 #include "base/ios/ios_util.h"
 #include "base/mac/scoped_cftyperef.h"
-#include "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #import "components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h"
 #include "components/omnibox/browser/autocomplete_input.h"
 #include "components/omnibox/browser/autocomplete_match.h"
 #include "components/omnibox/browser/autocomplete_result.h"
 #include "components/omnibox/browser/suggestion_answer.h"
 #include "ios/chrome/browser/ui/animation_util.h"
 #import "ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.h"
 #import "ios/chrome/browser/ui/omnibox/omnibox_popup_view_ios.h"
 #include "ios/chrome/browser/ui/omnibox/omnibox_util.h"
 #import "ios/chrome/browser/ui/omnibox/truncating_attributed_label.h"
 #include "ios/chrome/browser/ui/rtl_geometry.h"
 #include "ios/chrome/browser/ui/ui_util.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 #include "ios/chrome/grit/ios_theme_resources.h"
 #import "ios/third_party/material_components_ios/src/components/Typography/src/MaterialTypography.h"
 #import "ios/third_party/material_roboto_font_loader_ios/src/src/MaterialRobotoFontLoader.h"
 #include "net/base/escape.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 namespace {
 const int kRowCount = 6;
 const CGFloat kRowHeight = 48.0;
 const CGFloat kAnswerRowHeight = 64.0;
 const CGFloat kTopAndBottomPadding = 8.0;
 // The color of the main text of a suggest cell.
 UIColor* SuggestionTextColor() {
   return [UIColor colorWithWhite:(51 / 255.0) alpha:1.0];
 }
 // The color of the detail text of a suggest cell.
@@ skipping 45 matching lines @@
 
   OmniboxPopupViewIOS* _popupView;  // weak, owns us
 
   // Fetcher for Answers in Suggest images.
   std::unique_ptr<image_fetcher::IOSImageDataFetcherWrapper> imageFetcher_;
 
   // The data source.
   AutocompleteResult _currentResult;
 
   // Array containing the OmniboxPopupMaterialRow objects displayed in the view.
-  base::scoped_nsobject<NSArray> _rows;
+  NSArray* _rows;
 
   // The height of the keyboard. Used to determine the content inset for the
   // scroll view.
   CGFloat keyboardHeight_;
 }
 
 @end
 
 @implementation OmniboxPopupMaterialViewController
 
@@ skipping 21 matching lines @@
                             name:UIKeyboardDidShowNotification
                           object:nil];
     }
   }
   return self;
 }
 
 - (void)dealloc {
   self.tableView.delegate = nil;
   [[NSNotificationCenter defaultCenter] removeObserver:self];
-  [super dealloc];
 }
 
 - (UIScrollView*)scrollView {
   return (UIScrollView*)self.tableView;
 }
 
 - (void)viewDidLoad {
   [super viewDidLoad];
 
   // Initialize the same size as the parent view, autoresize will correct this.
@@ skipping 15 matching lines @@
   UIFont* bigBoldFont =
       [[MDFRobotoFontLoader sharedInstance] mediumFontOfSize:bigFont.pointSize];
   _smallFont.reset(CTFontCreateWithName((CFStringRef)smallFont.fontName,
                                         smallFont.pointSize, NULL));
   _bigFont.reset(CTFontCreateWithName((CFStringRef)bigFont.fontName,
                                       bigFont.pointSize, NULL));
   _smallBoldFont.reset(CTFontCreateWithName((CFStringRef)smallBoldFont.fontName,
                                             smallBoldFont.pointSize, NULL));
   _bigBoldFont.reset(CTFontCreateWithName((CFStringRef)bigBoldFont.fontName,
                                           bigBoldFont.pointSize, NULL));
-  NSMutableArray* rowsBuilder = [[[NSMutableArray alloc] init] autorelease];
+  NSMutableArray* rowsBuilder = [[NSMutableArray alloc] init];
   for (int i = 0; i < kRowCount; i++) {
-    OmniboxPopupMaterialRow* row = [[[OmniboxPopupMaterialRow alloc]
-        initWithIncognito:_incognito] autorelease];
+    OmniboxPopupMaterialRow* row =
+        [[OmniboxPopupMaterialRow alloc] initWithIncognito:_incognito];
     row.accessibilityIdentifier =
         [NSString stringWithFormat:@"omnibox suggestion %i", i];
     row.autoresizingMask = UIViewAutoresizingFlexibleWidth;
     [rowsBuilder addObject:row];
     [row.appendButton addTarget:self
                          action:@selector(appendButtonTapped:)
                forControlEvents:UIControlEventTouchUpInside];
     [row.appendButton setTag:i];
     row.rowHeight = kRowHeight;
   }
-  _rows.reset([rowsBuilder copy]);
+  _rows = [rowsBuilder copy];
 
   // Table configuration.
   self.tableView.allowsMultipleSelectionDuringEditing = NO;
   self.tableView.separatorStyle = UITableViewCellSeparatorStyleNone;
   self.tableView.separatorInset = UIEdgeInsetsZero;
   if ([self.tableView respondsToSelector:@selector(setLayoutMargins:)]) {
     [self.tableView setLayoutMargins:UIEdgeInsetsZero];
   }
   self.automaticallyAdjustsScrollViewInsets = NO;
   [self.tableView setContentInset:UIEdgeInsetsMake(kTopAndBottomPadding, 0,
                                                    kTopAndBottomPadding, 0)];
 }
 
 - (void)didReceiveMemoryWarning {
   [super didReceiveMemoryWarning];
   if (![self isViewLoaded]) {
     _smallFont.reset();
     _bigFont.reset();
     _smallBoldFont.reset();
     _bigBoldFont.reset();
-    _rows.reset();
+    _rows = nil;
   }
 }
 
 - (void)traitCollectionDidChange:(UITraitCollection*)previousTraitCollection {
   [self layoutRows];
 }
 
 #pragma mark -
 #pragma mark Updating data and UI
 
@@ skipping 189 matching lines @@
     frame = detailTextLabel.frame;
     frame.size.width -= kLTRTextInRTLLayoutLeftPadding - frame.origin.x;
     frame.origin.x = kLTRTextInRTLLayoutLeftPadding;
     detailTextLabel.frame = frame;
   }
 }
 
 - (NSMutableAttributedString*)attributedStringWithAnswerLine:
     (const SuggestionAnswer::ImageLine&)line {
   NSMutableAttributedString* result =
-      [[[NSMutableAttributedString alloc] initWithString:@""] autorelease];
+      [[NSMutableAttributedString alloc] initWithString:@""];
 
   for (size_t i = 0; i < line.text_fields().size(); i++) {
     const SuggestionAnswer::TextField& field = line.text_fields()[i];
     [result
         appendAttributedString:[self attributedStringWithString:field.text()
                                                            type:field.type()]];
   }
 
-  base::scoped_nsobject<NSAttributedString> spacer(
-      [[NSAttributedString alloc] initWithString:@"  "]);
+  NSAttributedString* spacer =
+      [[NSAttributedString alloc] initWithString:@"  "];
   if (line.additional_text() != nil) {
     const SuggestionAnswer::TextField* field = line.additional_text();
     [result appendAttributedString:spacer];
     [result
         appendAttributedString:[self attributedStringWithString:field->text()
                                                            type:field->type()]];
   }
 
   if (line.status_text() != nil) {
     const SuggestionAnswer::TextField* field = line.status_text();
@@ skipping 81 matching lines @@
   NSString* unescapedString =
       base::SysUTF16ToNSString(net::UnescapeForHTML(string));
   // TODO(jdonnelly): Remove this tag stripping once the JSON parsing class
   // handles HTML tags.
   unescapedString = [unescapedString stringByReplacingOccurrencesOfString:@"<b>"
                                                                withString:@""];
   unescapedString =
       [unescapedString stringByReplacingOccurrencesOfString:@"</b>"
                                                  withString:@""];
 
-  return [[[NSAttributedString alloc] initWithString:unescapedString
-                                          attributes:attributes] autorelease];
+  return [[NSAttributedString alloc] initWithString:unescapedString
+                                         attributes:attributes];
 }
 
 - (void)updateMatches:(const AutocompleteResult&)result
         withAnimation:(BOOL)animation {
   AutocompleteResult oldResults;
   AutocompleteInput emptyInput;
   oldResults.Swap(&_currentResult);
   _currentResult.CopyOldMatches(emptyInput, result, nil);
 
   [self layoutRows];
@@ skipping 100 matching lines @@
 #pragma mark UIScrollViewDelegate
 
 - (void)scrollViewDidScroll:(UIScrollView*)scrollView {
   // Setting the top inset of the scrollView to |kTopAndBottomPadding| causes a
   // one time scrollViewDidScroll to |-kTopAndBottomPadding|.  It's easier to
   // just ignore this one scroll tick.
   if (scrollView.contentOffset.y == 0 - kTopAndBottomPadding)
     return;
 
   _popupView->DidScroll();
-  for (OmniboxPopupMaterialRow* row in _rows.get()) {
+  for (OmniboxPopupMaterialRow* row in _rows) {
     row.highlighted = NO;
   }
 }
 
 // Set text alignment for popup cells.
 - (void)setTextAlignment:(NSTextAlignment)alignment {
   _alignment = alignment;
 }
 
 - (BOOL)isSearchMatch:(const AutocompleteMatch::Type&)type {
   return (type == AutocompleteMatchType::NAVSUGGEST ||
           type == AutocompleteMatchType::SEARCH_WHAT_YOU_TYPED ||
           type == AutocompleteMatchType::SEARCH_HISTORY ||
           type == AutocompleteMatchType::SEARCH_SUGGEST ||
           type == AutocompleteMatchType::SEARCH_OTHER_ENGINE);
 }
 
 - (NSMutableAttributedString*)
 attributedStringWithString:(NSString*)text
            classifications:(const ACMatchClassifications*)classifications
                  smallFont:(BOOL)smallFont
                      color:(UIColor*)defaultColor
                   dimColor:(UIColor*)dimColor {
   if (text == nil)
     return nil;
 
   CTFontRef fontRef = smallFont ? _smallFont : _bigFont;
 
   NSMutableAttributedString* as =
-      [[[NSMutableAttributedString alloc] initWithString:text] autorelease];
+      [[NSMutableAttributedString alloc] initWithString:text];
 
   // Set the base attributes to the default font and color.
   NSDictionary* dict = [NSDictionary
-      dictionaryWithObjectsAndKeys:(id)fontRef, (NSString*)kCTFontAttributeName,
+      dictionaryWithObjectsAndKeys:(__bridge id)fontRef,

[rohitrao (ping after 24h), 2017/02/24 13:40:31]

There's a CL out to remove all of the CTFont code from this file.  Might be
worth waiting for that to land, which should make this conversion slightly less
complicated.

[Justin Donnelly, 2017/02/24 15:40:39]

This landed yesterday: http://crrev.com/2695413003.

[stkhapugin, 2017/03/01 17:43:58]

Merged this in

+                                   (NSString*)kCTFontAttributeName,
                                    defaultColor.CGColor,
                                    (NSString*)kCTForegroundColorAttributeName,
                                    nil];
   [as addAttributes:dict range:NSMakeRange(0, [text length])];
 
   if (classifications != NULL) {
     CTFontRef boldFontRef = smallFont ? _smallBoldFont : _bigBoldFont;
 
     for (ACMatchClassifications::const_iterator i = classifications->begin();
          i != classifications->end(); ++i) {
       const BOOL isLast = (i + 1) == classifications->end();
       const size_t nextOffset = (isLast ? [text length] : (i + 1)->offset);
       const NSInteger location = static_cast<NSInteger>(i->offset);
       const NSInteger length = static_cast<NSInteger>(nextOffset - i->offset);
       // Guard against bad, off-the-end classification ranges due to
       // crbug.com/121703 and crbug.com/131370.
       if (i->offset + length > [text length] || length <= 0)
         break;
       const NSRange range = NSMakeRange(location, length);
       if (0 != (i->style & ACMatchClassification::MATCH)) {
         [as addAttribute:(id)kCTFontAttributeName
-                   value:(id)boldFontRef
+                   value:(__bridge id)boldFontRef

[rohitrao (ping after 24h), 2017/02/24 13:40:31]

What does __bridge do?

[stkhapugin, 2017/03/01 17:43:58]

__bridge is a type of cast that tells ARC to not do anything to a Core
Foundation reference. It seems like this is not necessary here after rebase
because |boldFontRef| is now UIFont. 

                    range:range];
       }
 
       if (0 != (i->style & ACMatchClassification::DIM)) {
         [as addAttribute:(id)kCTForegroundColorAttributeName
                    value:(id)dimColor.CGColor
                    range:range];
       }
     }
   }
@@ skipping 62 matching lines @@
     // The delete button never disappears if you don't call this after a tap.
     // It doesn't seem to be required anywhere else.
     [_rows[indexPath.row] prepareForReuse];
     const AutocompleteMatch& match =
         ((const AutocompleteResult&)_currentResult).match_at(indexPath.row);
     _popupView->DeleteMatch(match);
   }
 }
 
 @end