Chromium Code Reviews

Issue 27079003: Use the system stdint.h on Windows. (Closed)

Created:
7 years, 2 months ago by bungeman-chromium
Modified:
7 years, 2 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews
Visibility:
Public.

Description

Use the system stdint.h on Windows. This is now possible since VC2010 and later provide a stdint.h. VC2008 has been deprecated for building Chromium for a full year now. There are a number of stdint.h implementations in the codebase, some of which hide others, and most of which are not complete, and some are not named stdint.h. The one here in icu is pwin32.h and it is the last file which implements parts of stdint.h which prevents Blink from using the system stdint.h. R=jshin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228516

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+5 lines, -5 lines)
M patches/vs2012.patch View 1 chunk +4 lines, -4 lines 0 comments
M source/common/unicode/pwin32.h View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 4 (0 generated)
bungeman-chromium
See https://codereview.chromium.org/26358014/ to see the first part of the effort to move Blink to the ...
7 years, 2 months ago (2013-10-14 13:31:26 UTC) #1
bungeman-chromium
I took a look at the win failure and it turns out to just be ...
7 years, 2 months ago (2013-10-14 15:40:37 UTC) #2
jungshik at Google
On 2013/10/14 15:40:37, bungeman2 wrote: > I took a look at the win failure and ...
7 years, 2 months ago (2013-10-14 20:16:09 UTC) #3
bungeman-chromium
7 years, 2 months ago (2013-10-14 20:23:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r228516 (presubmit successful).

Powered by Google App Engine