Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: src/compiler.cc

Issue 2707873002: Collect type profile for DevTools. (Closed)
Patch Set: Explain why throw is needed in message test. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/ast-numbering.cc ('k') | src/compiler/bytecode-graph-builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 2c9c888b6f916aefa84d2480d2252352ad3a9c8a..1c08a9d5cf563ab13f2029e5d4883ccda609728d 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -478,9 +478,24 @@ bool Renumber(ParseInfo* parse_info,
Compiler::EagerInnerFunctionLiterals* eager_literals) {
RuntimeCallTimerScope runtimeTimer(parse_info->isolate(),
&RuntimeCallStats::CompileRenumber);
+
+ // CollectTypeProfile uses its own feedback slots. If we have existing
+ // FeedbackMetadata, we can only collect type profile, if the feedback vector
+ // has the appropriate slots.
+ bool collect_type_profile;
+ if (parse_info->shared_info().is_null() ||
+ parse_info->shared_info()->feedback_metadata()->length() == 0) {
+ collect_type_profile = FLAG_type_profile &&
+ parse_info->script()->type() == Script::TYPE_NORMAL;
+ } else {
+ collect_type_profile =
+ parse_info->shared_info()->feedback_metadata()->HasTypeProfileSlot();
+ }
+
if (!AstNumbering::Renumber(
parse_info->isolate()->stack_guard()->real_climit(),
- parse_info->zone(), parse_info->literal(), eager_literals)) {
+ parse_info->zone(), parse_info->literal(), eager_literals,
+ collect_type_profile)) {
return false;
}
if (!parse_info->shared_info().is_null()) {
« no previous file with comments | « src/ast/ast-numbering.cc ('k') | src/compiler/bytecode-graph-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698