Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: src/interpreter/bytecode-array-builder.h

Issue 2707873002: Collect type profile for DevTools. (Closed)
Patch Set: Delete unused var Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecode-array-builder.h
diff --git a/src/interpreter/bytecode-array-builder.h b/src/interpreter/bytecode-array-builder.h
index 6c09f5cdf40cdd6ae59bdd1758dc87bb41302b65..c5f77d44f1fb9e45a701ee664004ecf08d96f6a5 100644
--- a/src/interpreter/bytecode-array-builder.h
+++ b/src/interpreter/bytecode-array-builder.h
@@ -137,6 +137,11 @@ class V8_EXPORT_PRIVATE BytecodeArrayBuilder final
Register object, Register name, DataPropertyInLiteralFlags flags,
int feedback_slot);
+ // Collect type information for developer tools. The value for which we
+ // record the type is stored in the accumulator.
+ // TODO(franzih): Do not pass the name, instead use the source position.
rmcilroy 2017/03/13 10:50:59 Any not to use source position now? This would pro
Franzi 2017/03/13 12:01:56 I'll land as is to keep CL somewhat shorter.
+ BytecodeArrayBuilder& CollectTypeProfile(Register name, int feedback_slot);
+
// Store a property named by a property name. The value to be stored should be
// in the accumulator.
BytecodeArrayBuilder& StoreNamedProperty(Register object,

Powered by Google App Engine
This is Rietveld 408576698