Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: chrome/browser/extensions/api/gcm/gcm_apitest.cc

Issue 270783002: [GCM] Add more UMA to GCM (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address feedback Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/gcm/gcm_apitest.cc
diff --git a/chrome/browser/extensions/api/gcm/gcm_apitest.cc b/chrome/browser/extensions/api/gcm/gcm_apitest.cc
index 0ce8663ff12ce2115d5434f3b4ee5022392556a5..471051ab1eb116d1ef4ed226707361754d305d00 100644
--- a/chrome/browser/extensions/api/gcm/gcm_apitest.cc
+++ b/chrome/browser/extensions/api/gcm/gcm_apitest.cc
@@ -14,6 +14,7 @@
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/ui_test_utils.h"
+#include "google_apis/gcm/gcm_client.h"
namespace {
@@ -151,6 +152,8 @@ IN_PROC_BROWSER_TEST_F(GcmApiTest, SendMessageData) {
service()->last_sent_message();
gcm::GCMClient::MessageData::const_iterator iter;
+ EXPECT_EQ(100, message.time_to_live);
+
EXPECT_TRUE((iter = message.data.find("key1")) != message.data.end());
EXPECT_EQ("value1", iter->second);
@@ -158,6 +161,18 @@ IN_PROC_BROWSER_TEST_F(GcmApiTest, SendMessageData) {
EXPECT_EQ("value2", iter->second);
}
+IN_PROC_BROWSER_TEST_F(GcmApiTest, SendMessageDefaultTTL) {
+ StartCollecting();
+ ASSERT_TRUE(RunExtensionTest("gcm/functions/send_message_default_ttl"));
+
+ EXPECT_EQ("destination-id", service()->last_receiver_id());
+ const gcm::GCMClient::OutgoingMessage& message =
+ service()->last_sent_message();
+ gcm::GCMClient::MessageData::const_iterator iter;
+
+ EXPECT_EQ(gcm::GCMClient::OutgoingMessage::kMaximumTTL, message.time_to_live);
+}
+
IN_PROC_BROWSER_TEST_F(GcmApiTest, OnMessagesDeleted) {
ResultCatcher catcher;
catcher.RestrictToProfile(profile());

Powered by Google App Engine
This is Rietveld 408576698