[GCM] Add more UMA to GCM

google_apis/gcm/engine/registration_request.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/gcm/engine/registration_request.h"
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 74 matching lines @@
 
 RegistrationRequest::RequestInfo::RequestInfo(
     uint64 android_id,
     uint64 security_token,
     const std::string& app_id,
     const std::vector<std::string>& sender_ids)
     : android_id(android_id),
       security_token(security_token),
       app_id(app_id),
       sender_ids(sender_ids) {
+  UMA_HISTOGRAM_COUNTS("GCM.RegistrationSenderNumber", sender_ids.size());

[fgorski, 2014/05/08 18:08:36]

nit: wouldn't that be more suitable in start?

[jianli, 2014/05/08 18:40:07]

Done.

 }
 
 RegistrationRequest::RequestInfo::~RequestInfo() {}
 
 RegistrationRequest::RegistrationRequest(
     const GURL& registration_url,
     const RequestInfo& request_info,
     const net::BackoffEntry::Policy& backoff_policy,
     const RegistrationCallback& callback,
     int max_retry_count,
@@ skipping 44 matching lines @@
     if (!senders.empty())
       senders.append(",");
     senders.append(*iter);
   }
   BuildFormEncoding(kSenderKey, senders, &body);
 
   DVLOG(1) << "Performing registration for: " << request_info_.app_id;
   DVLOG(1) << "Registration request: " << body;
   url_fetcher_->SetUploadData(kRegistrationRequestContentType, body);
   recorder_->RecordRegistrationSent(request_info_.app_id, senders);
+  request_start_time_ = base::TimeTicks::Now();
   url_fetcher_->Start();
 }
 
 void RegistrationRequest::RetryWithBackoff(bool update_backoff) {
   if (update_backoff) {
     DCHECK_GT(retries_left_, 0);
     --retries_left_;
     url_fetcher_.reset();
     backoff_entry_.InformOfRequest(false);
   }
@@ skipping 76 matching lines @@
     }
 
     status = REACHED_MAX_RETRIES;
     recorder_->RecordRegistrationResponse(
         request_info_.app_id,
         request_info_.sender_ids,
         status);
     RecordRegistrationStatusToUMA(status);
   }
 
+  if (status == SUCCESS) {
+    UMA_HISTOGRAM_COUNTS("GCM.RegistrationRetryNumber",

[fgorski, 2014/05/08 18:08:36]

Do we not care about the retry number if we don't end with success?

[jianli, 2014/05/08 18:40:07]

Yes. See my comment above.

+                         backoff_entry_.failure_count() + 1);

[fgorski, 2014/05/08 18:08:36]

nit: Technically number of retries is = failure count
number of total tries = failure count + 1

[jianli, 2014/05/08 18:40:07]

Original I mean the UMA was for total number of requests being asked. But based
on the UMA name, I think we really mean for the total number of retries. If the
checkin succeeds at 1st try, the UMA count should be reported as 0. I updated
the code to report fail_count.

+    UMA_HISTOGRAM_TIMES("GCM.RegistrationCompleteTime",
+                        base::TimeTicks::Now() - request_start_time_);
+  }
   callback_.Run(status, token);
 }
 
 }  // namespace gcm