[GCM] Add more UMA to GCM

google_apis/gcm/engine/checkin_request.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/gcm/engine/checkin_request.h"
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "google_apis/gcm/monitoring/gcm_stats_recorder.h"
@@ skipping 126 matching lines @@
   }
 
   std::string upload_data;
   CHECK(request.SerializeToString(&upload_data));
 
   url_fetcher_.reset(
       net::URLFetcher::Create(checkin_url_, net::URLFetcher::POST, this));
   url_fetcher_->SetRequestContext(request_context_getter_);
   url_fetcher_->SetUploadData(kRequestContentType, upload_data);
   recorder_->RecordCheckinInitiated(request_info_.android_id);
+  request_start_time_ = base::TimeTicks::Now();
   url_fetcher_->Start();
 }
 
 void CheckinRequest::RetryWithBackoff(bool update_backoff) {
   if (update_backoff) {
     backoff_entry_.InformOfRequest(false);
     url_fetcher_.reset();
   }
 
   if (backoff_entry_.ShouldRejectRequest()) {
@@ skipping 55 matching lines @@
       !response_proto.has_security_token() ||
       response_proto.android_id() == 0 ||
       response_proto.security_token() == 0) {
     LOG(ERROR) << "Android ID or security token is 0. Retrying.";
     RecordCheckinStatusAndReportUMA(ZERO_ID_OR_TOKEN, recorder_, true);
     RetryWithBackoff(true);
     return;
   }
 
   RecordCheckinStatusAndReportUMA(SUCCESS, recorder_, false);
+  UMA_HISTOGRAM_COUNTS("GCM.CheckinRetryNumber",

[fgorski, 2014/05/08 18:08:36]

Do we report try count if the checkin fails or do we attempt to check in
infinitely?

[jianli, 2014/05/08 18:40:07]

What we care about is the number of retries to do the checkin successfully. If
the checkin failed due to HTTP_BAD_REQUEST or HTTP_UNAUTHORIZED, it will be
reported by GCM.CheckinRequestStatus. Then we don't care about the number of
retries since no matter how many the checkin is retried, it should always fail.

+                       backoff_entry_.failure_count() + 1);
+  UMA_HISTOGRAM_TIMES("GCM.CheckinCompleteTime",
+                      base::TimeTicks::Now() - request_start_time_);
   callback_.Run(response_proto);
 }
 
 }  // namespace gcm