tools/metrics/histograms/histograms.xml - Issue 2707783004: [remote suggestions] Add a new histogram for recording the time since a snippet was fetched.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2707783004: [remote suggestions] Add a new histogram for recording the time since a snippet was fetched. (Closed)

Patch Set: Address comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index f7fd8937c039f19f0327adf824671dab93cf2849..48bcb5040fc048ea4fc1814f68e7bd29765022f1 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -39834,13 +39834,12 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

-<histogram name="NewTabPage.ContentSuggestions.TimeSinceLastBackgroundFetch"

Marc Treib 2017/02/21 11:53:48 We never remove entries from here - we keep them,

markusheintz_ 2017/02/21 15:28:57 Done.

+<histogram name="NewTabPage.ContentSuggestions.TimeSinceSuggestionFetched"

units="ms">

<owner>markusheintz@chromium.org</owner>

- Android: The time since the last successful background fetch of remote

- content suggestions. Recorded when the user looks at content suggestions on

- the NTP.

+ Android: The time since the displayed content suggestions was fetched.

+ Recorded when the user looks at content suggestions on the NTP.

Marc Treib 2017/02/21 11:53:48 Please mention that it's only recorded for ARTICLE

markusheintz_ 2017/02/21 15:28:57 Done.

</summary>

</histogram>

« no previous file with comments | « components/ntp_snippets/content_suggestions_metrics.cc ('k') | no next file » | no next file with comments »