Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1649)

Unified Diff: chrome/browser/icon_loader_chromeos.cc

Issue 2707753004: Switch IconLoader::ReadIconThreadID from FILE to UI (Closed)
Patch Set: +comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/icon_loader_chromeos.cc
diff --git a/chrome/browser/icon_loader_chromeos.cc b/chrome/browser/icon_loader_chromeos.cc
index 52ae44d7b2d49be7f0d268e3dbec62355062d325..30f0005b8a7d2922c2b83145ecc951ffc76089d1 100644
--- a/chrome/browser/icon_loader_chromeos.cc
+++ b/chrome/browser/icon_loader_chromeos.cc
@@ -192,7 +192,9 @@ IconLoader::IconGroup IconLoader::GroupForFilepath(
// static
content::BrowserThread::ID IconLoader::ReadIconThreadID() {
- return content::BrowserThread::FILE;
+ // ReadIcon touches non thread safe ResourceBundle images, so it must be on
+ // the UI thread.
+ return content::BrowserThread::UI;
}
void IconLoader::ReadIcon() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698