Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 270773004: ui: Move android test (scroller) into gfx_unittests target. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

ui: Move android test (scroller) into gfx_unittests target. This test does not seem to need any ResourceBundle initialization and does not seem to depend on any global state or extra setup, so it should be fine to move it straightforward into gfx_unittests without any other modifications. BUG=331829 TEST=ui_unittests, gfx_unittests TBR=ben@chromium.org, danakj@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269922

Patch Set 1 #

Patch Set 2 : ui_unittests still needs native_test_native_code target #

Patch Set 3 : fix path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M ui/gfx/gfx.gyp View 1 1 chunk +10 lines, -0 lines 0 comments Download
M ui/ui_unittests.gyp View 1 2 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
tfarina
TBRing... (Please, rubber stamp?) Thanks,
6 years, 7 months ago (2014-05-12 03:10:35 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-12 03:10:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/270773004/1
6 years, 7 months ago (2014-05-12 03:10:54 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-12 06:24:39 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-12 08:02:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/152922)
6 years, 7 months ago (2014-05-12 08:02:43 UTC) #6
danakj
LGTM
6 years, 7 months ago (2014-05-12 14:04:54 UTC) #7
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-12 16:57:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/270773004/1
6 years, 7 months ago (2014-05-12 16:59:07 UTC) #9
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 7 months ago (2014-05-12 17:02:04 UTC) #10
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-12 18:59:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/270773004/10001
6 years, 7 months ago (2014-05-12 19:00:33 UTC) #12
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-12 19:17:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/270773004/30001
6 years, 7 months ago (2014-05-12 19:18:14 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-12 22:52:56 UTC) #15
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 7 months ago (2014-05-12 23:50:25 UTC) #16
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-12 23:51:35 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/270773004/30001
6 years, 7 months ago (2014-05-12 23:53:44 UTC) #18
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 23:56:27 UTC) #19
Message was sent while issue was closed.
Change committed as 269922

Powered by Google App Engine
This is Rietveld 408576698