Implement AstBuilder support for library, part, and part-of declarations.

pkg/analyzer/test/generated/parser_fasta_test.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/src/generated/parser.dart' as analyzer;
 import 'package:front_end/src/fasta/analyzer/ast_builder.dart';
 import 'package:front_end/src/fasta/analyzer/element_store.dart';
@@ skipping 565 matching lines @@
   @failingTest
   void test_parseCompilationUnit_builtIn_asFunctionName() {
     // TODO(paulberry,ahe): Fasta's parser is confused when one of the built-in
     // identifiers `export`, `import`, `library`, `part`, or `typedef` appears
     // as the name of a top level function with an implicit return type.
     super.test_parseCompilationUnit_builtIn_asFunctionName();
   }
 
   @override
   @failingTest
-  void test_parseCompilationUnit_directives_multiple() {
-    // TODO(paulberry): Unhandled event: LibraryName
-    super.test_parseCompilationUnit_directives_multiple();
-  }
-
-  @override
-  @failingTest
-  void test_parseCompilationUnit_directives_single() {
-    // TODO(paulberry): Unhandled event: LibraryName
-    super.test_parseCompilationUnit_directives_single();
-  }
-
-  @override
-  @failingTest
   void test_parseCompilationUnit_empty() {
     // TODO(paulberry): No objects placed on stack
     super.test_parseCompilationUnit_empty();
   }
 
   @override
   @failingTest
   void test_parseCompilationUnit_exportAsPrefix() {
     // TODO(paulberry): TODO(paulberry,ahe): Fasta parser doesn't appear to handle this case correctly.
     super.test_parseCompilationUnit_exportAsPrefix();
@@ skipping 193 matching lines @@
 
   @override
   @failingTest
   void test_parseCompilationUnitMember_variableSet() {
     // TODO(paulberry): Unhandled event: FieldInitializer
     super.test_parseCompilationUnitMember_variableSet();
   }
 
   @override
   @failingTest
-  void test_parseDirective_library() {
-    // TODO(paulberry): Unhandled event: LibraryName
-    super.test_parseDirective_library();
-  }
-
-  @override
-  @failingTest
-  void test_parseDirective_part() {
-    // TODO(paulberry): Unhandled event: Part
-    super.test_parseDirective_part();
-  }
-
-  @override
-  @failingTest
-  void test_parseDirective_partOf() {
-    // TODO(paulberry): Unhandled event: PartOf
-    super.test_parseDirective_partOf();
-  }
-
-  @override
-  @failingTest
   void test_parseDirectives_complete() {
-    // TODO(paulberry): Unhandled event: LibraryName
+    // TODO(paulberry,ahe): Fasta doesn't support script tags yet.

[ahe, 2017/02/20 09:59:39]

Can I assume this is low priority?

[Paul Berry, 2017/02/20 14:48:31]

Agreed, It's pretty low priority IMO.

     super.test_parseDirectives_complete();
   }
 
   @override
   @failingTest
   void test_parseDirectives_empty() {
     // TODO(paulberry): No objects placed on stack
     super.test_parseDirectives_empty();
   }
 
   @override
   @failingTest
   void test_parseDirectives_mixed() {
-    // TODO(paulberry): Unhandled event: LibraryName
+    // TODO(paulberry,ahe): This test verifies the analyzer parser's ability to
+    // stop parsing as soon as the first non-directive is encountered; this is
+    // useful for quickly traversing an import graph.  Consider adding a similar
+    // ability to Fasta's parser.

[ahe, 2017/02/20 09:59:39]

I think that should be easy. Let me know how soon you need this.

[Paul Berry, 2017/02/20 14:48:31]

It would be nice to get this within the next couple of weeks.  I have some code
in pkg/front_end/lib/src/dependency_grapher_impl.dart that I'd like to switch
over to using Fasta, and it would likely take a performance hit without this
feature.

     super.test_parseDirectives_mixed();
   }
 
   @override
   @failingTest
-  void test_parseDirectives_multiple() {
-    // TODO(paulberry): Unhandled event: LibraryName
-    super.test_parseDirectives_multiple();
-  }
-
-  @override
-  @failingTest
   void test_parseDirectives_script() {
     // TODO(paulberry): No objects placed on stack
     super.test_parseDirectives_script();
   }
 
   @override
   @failingTest
-  void test_parseDirectives_single() {
-    // TODO(paulberry): Unhandled event: LibraryName
-    super.test_parseDirectives_single();
-  }
-
-  @override
-  @failingTest
   void test_parseEnumDeclaration_one() {
     // TODO(paulberry): Unhandled event: Enum
     super.test_parseEnumDeclaration_one();
   }
 
   @override
   @failingTest
   void test_parseEnumDeclaration_trailingComma() {
     // TODO(paulberry): Unhandled event: Enum
     super.test_parseEnumDeclaration_trailingComma();
@@ skipping 65 matching lines @@
 
   @override
   @failingTest
   void test_parseImportDirective_configuration_single() {
     // TODO(paulberry): Implement endConditionalUri
     super.test_parseImportDirective_configuration_single();
   }
 
   @override
   @failingTest
-  void test_parseLibraryDirective() {
-    // TODO(paulberry): Unhandled event: LibraryName
-    super.test_parseLibraryDirective();
-  }
-
-  @override
-  @failingTest
-  void test_parsePartDirective() {
-    // TODO(paulberry): Unhandled event: Part
-    super.test_parsePartDirective();
-  }
-
-  @override
-  @failingTest
   void test_parsePartOfDirective_name() {
-    // TODO(paulberry): Unhandled event: PartOf
+    // TODO(paulberry,ahe): Thes test verifies that even if URIs in "part of"
+    // declarations are enabled, a construct of the form "part of identifier;"
+    // is still properly handled.  URIs in "part of" declarations are not
+    // supported by Fasta yet.

[ahe, 2017/02/20 09:59:39]

Yeah. I think this is legacy syntax, and I generally try to keep support for old
syntax for improved error recovery.

     super.test_parsePartOfDirective_name();
   }
 
   @override
   @failingTest
   void test_parsePartOfDirective_uri() {
     // TODO(paulberry,ahe): URIs in "part of" declarations are not supported by
     // Fasta.
     super.test_parsePartOfDirective_uri();
   }
@@ skipping 107 matching lines @@
   void test_parseTypeAlias_genericFunction_typeParameters_voidReturnType() {
     super.test_parseTypeAlias_genericFunction_typeParameters_voidReturnType();
   }
 
   @override
   @failingTest
   void test_parseTypeAlias_genericFunction_voidReturnType() {
     super.test_parseTypeAlias_genericFunction_voidReturnType();
   }
 }