appengine/findit/crash/loglinear/changelist_features/test/min_distance_test.py - Issue 2707603002: [Predator] Generate all changelogs in regression ranges instead of only matched changelogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/crash/loglinear/changelist_features/test/min_distance_test.py

Issue 2707603002: [Predator] Generate all changelogs in regression ranges instead of only matched changelogs (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/crash/loglinear/changelist_classifier.py ('k') | appengine/findit/crash/loglinear/changelist_features/test/top_frame_index_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/crash/loglinear/changelist_features/test/min_distance_test.py

diff --git a/appengine/findit/crash/loglinear/changelist_features/test/min_distance_test.py b/appengine/findit/crash/loglinear/changelist_features/test/min_distance_test.py

index 91d0090d638e1bbef79c1d4d3f9e878d4d3d7c80..afe2b8127df8f6d1504382be6524017d2616dc17 100644

--- a/appengine/findit/crash/loglinear/changelist_features/test/min_distance_test.py

+++ b/appengine/findit/crash/loglinear/changelist_features/test/min_distance_test.py

@@ -12,10 +12,9 @@ from crash.loglinear.changelist_features import min_distance

from crash.loglinear.feature import ChangedFile

from crash.stacktrace import CallStack

from crash.stacktrace import StackFrame

+from crash.stacktrace import StackInfo

from crash.stacktrace import Stacktrace

-from crash.suspect import AnalysisInfo

from crash.suspect import Suspect

-from crash.suspect import StackInfo

from crash.test.predator_testcase import PredatorTestCase

from libs.gitiles.blame import Blame

from libs.gitiles.blame import Region

@@ -141,9 +140,7 @@ class MinDistanceTest(PredatorTestCase):

distance = _MAXIMUM + 1

touched_file_to_stack_info = {

FileChangeInfo(ChangeType.MODIFY, 'file', 'file'):

- AnalysisInfo(

- min_distance=distance,

- min_distance_frame=_MOCK_FRAME)

+ StackInfo(_MOCK_FRAME, 0)

}

self.mock(min_distance.MinDistanceFeature,

'DistanceBetweenTouchedFileAndStacktrace',

@@ -195,12 +192,9 @@ class MinDistanceTest(PredatorTestCase):

dep_rolls={'src/': DependencyRoll('src/', 'https://repo', '0', '4')})

suspect = self._GetMockSuspect()

- distance = _MAXIMUM + 1

touched_file_to_stack_info = {

FileChangeInfo(ChangeType.MODIFY, 'file', 'file'):

- AnalysisInfo(

- min_distance=distance,

- min_distance_frame=_MOCK_FRAME)

+ StackInfo(_MOCK_FRAME, 0)

}

self.mock(min_distance.MinDistanceFeature,

'DistanceBetweenTouchedFileAndStacktrace',

@@ -226,9 +220,7 @@ class MinDistanceTest(PredatorTestCase):

distance = 42

touched_file_to_stack_info = {

FileChangeInfo(ChangeType.MODIFY, 'file', 'file'):

- AnalysisInfo(

- min_distance=distance,

- min_distance_frame=_MOCK_FRAME)

+ StackInfo(_MOCK_FRAME, 0)

}

frame = StackFrame(0, 'src/', 'func', 'f.cc', 'f.cc', [7], 'https://repo')

self.mock(min_distance.MinDistanceFeature,