Whitelist allowed test names

recipe_engine/recipe_test_api.py

 # Copyright 2016 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 import contextlib
 import inspect
+import re
 
 from collections import namedtuple, defaultdict
 
 from .util import ModuleInjectionSite, static_call, static_wraps
 from .types import freeze
 
 def combineify(name, dest, a, b, overwrite=False):
   """
   Combines dictionary members in two objects into a third one using addition.
 
@@ skipping 163 matching lines @@
     return ret
 
   def __repr__(self):
     return "ModuleTestData(%r)" % super(ModuleTestData, self).__repr__()
 
 
 PostprocessHook = namedtuple(
   'PostprocessHook', 'func args kwargs filename lineno')
 
 
+def is_valid_test_name(name):
+  return bool(re.match(r'^(\w)+$', name))
+
+
 class TestData(BaseTestData):
   def __init__(self, name=None):
     super(TestData, self).__init__()
+    # Allow empty names; sometimes we create test datas to merge two test datas
+    # together.
+    if name and not is_valid_test_name(name):
+      raise ValueError("Invalid test name %r" % name)
+
     self.name = name
     self.properties = {}  # key -> val
     self.mod_data = defaultdict(ModuleTestData)
     self.step_data = defaultdict(StepTestData)
     self.depend_on_data = {}
     self.expected_exception = None
     self.post_process_hooks = [] # list(PostprocessHook)
 
   def __add__(self, other):
     assert isinstance(other, TestData)
@@ skipping 443 matching lines @@
         )
     """
     ret = TestData()
     try:
       stk = inspect.stack()
       _, filename, lineno, _, _, _ = stk[1]
     finally:
       del stk
     ret.post_process(func, args, kwargs, filename, lineno)
     return ret