Whitelist allowed test names

recipe_engine/unittests/recipe_test_api_test.py

 #!/usr/bin/env python
 # Copyright 2015 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 import os
 import sys
 import unittest
 
 import test_env
 
 from recipe_engine import recipe_test_api
 
 class EXC(Exception):
   pass
 
 class TestExpectedException(unittest.TestCase):
   def testRecognizeException(self):
     """An expected exception is correctly recognized."""
-    test_data = recipe_test_api.TestData()
+    test_data = recipe_test_api.TestData("test")

[Paweł Hajdan Jr., 2017/02/21 09:53:31]

nit: Single quotes ' instead of double " (applies to entire CL).

     test_data.expect_exception(EXC.__name__)
     self.assertFalse(test_data.consumed)
 
     with test_data.should_raise_exception(EXC()) as should_raise:
       self.assertFalse(should_raise)
 
     with test_data.should_raise_exception(ValueError()) as should_raise:
       self.assertTrue(should_raise)
 
     self.assertTrue(test_data.consumed)
 
   def testNewException(self):
     """An unexpected exception results in being told to re-raise ."""
-    test_data = recipe_test_api.TestData()
+    test_data = recipe_test_api.TestData("test")
     self.assertTrue(test_data.consumed)
 
     with test_data.should_raise_exception(EXC()) as should_raise:
       self.assertTrue(should_raise)
 
     self.assertTrue(test_data.consumed)
 
   def testDisabledTestData(self):
     """Disabled test data correctly re-raises all exceptions."""
-    test_data = recipe_test_api.TestData()
+    test_data = recipe_test_api.TestData("test")
 
     with test_data.should_raise_exception(EXC()) as should_raise:
       self.assertTrue(should_raise)
 
+  def test_invalid_test_names(self):
+    for bad in ('bad name', 'a\////', 'b\\\\', 'c(*#&($'):
+      self.assertFalse(recipe_test_api.is_valid_test_name(bad))
+
+  def test_valid_test_names(self):
+    for good in ('good', 'with_underscores_now', 'and_numbers_1'):
+      self.assertTrue(recipe_test_api.is_valid_test_name(good))
+
 if __name__ == '__main__':
   unittest.main()