extensions/browser/api/cast_channel/cast_socket.h - Issue 2707543002: [Cast Channel] Fix "leaky" CastChannelOpenFunction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_socket.h

Issue 2707543002: [Cast Channel] Fix "leaky" CastChannelOpenFunction. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/cast_channel/cast_socket.h

diff --git a/extensions/browser/api/cast_channel/cast_socket.h b/extensions/browser/api/cast_channel/cast_socket.h

index 08a69b4bf8108467bb7c727ebfd6382f12906ed8..78a7bb0d5d8fa791e98b352b45acaa448e180341 100644

--- a/extensions/browser/api/cast_channel/cast_socket.h

+++ b/extensions/browser/api/cast_channel/cast_socket.h

@@ -70,6 +70,9 @@ class CastSocket : public ApiResource {

// Instead use Close().

// |callback| will be invoked with any ChannelError that occurred, or

// CHANNEL_ERROR_NONE if successful.

+ // If the CastSocket is destroyed while the connection is pending, |callback|

+ // will be invoked with CHANNEL_ERROR_UNKNOWN. In this case, invoking

+ // |callback| must not result in any re-entrancy behavior.

// |delegate| receives message receipt and error events.

// Ownership of |delegate| is transferred to this CastSocket.

virtual void Connect(std::unique_ptr<CastTransport::Delegate> delegate,