Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2707493002: Presubmit checks for the Pipa repository (Closed)

Created:
3 years, 10 months ago by veranika
Modified:
3 years, 10 months ago
Reviewers:
ftirelo
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Presubmit checks for the Pipa repository The presubmit script was heavily inspired by Sysygy's presubmit checks with some additions. BUG= R=ftirelo@chromium.org Committed: https://chromium.googlesource.com/chromium/pipa/+/433e5fbdedc3e1343e3614dd6fe7d2f597fb6fd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+456 lines, -1024 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
A PRESUBMIT.py View 1 chunk +270 lines, -0 lines 0 comments Download
D pipa/build/gitdeps.py View 1 chunk +0 lines, -953 lines 0 comments Download
A pipa/py/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A pipa/py/deps_utils.py View 1 chunk +95 lines, -0 lines 0 comments Download
A + pipa/py/gitdeps.py View 3 chunks +2 lines, -72 lines 0 comments Download
A pipa/py/test_utils/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A pipa/py/test_utils/presubmit.py View 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
veranika
3 years, 10 months ago (2017-02-17 19:31:14 UTC) #3
ftirelo
lgtm
3 years, 10 months ago (2017-02-17 19:42:41 UTC) #4
veranika
3 years, 10 months ago (2017-02-17 19:56:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
433e5fbdedc3e1343e3614dd6fe7d2f597fb6fd2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698