Refactor and improve code for pow.

runtime/vm/intermediate_language_arm64.cc

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_ARM64.
 #if defined(TARGET_ARCH_ARM64)
 
 #include "vm/intermediate_language.h"
 
 #include "vm/dart_entry.h"
@@ skipping 3588 matching lines @@
     result->set_in(1, Location::FpuRegisterLocation(V1));
   }
   if (recognized_kind() == MethodRecognizer::kMathDoublePow) {
     result->AddTemp(Location::FpuRegisterLocation(V30));
   }
   result->set_out(0, Location::FpuRegisterLocation(V0));
   return result;
 }
 
 
+// Pseudo code:
+// if (exponent == 0.0) return 1.0;
+// // Speed up simple cases.
+// if (exponent == 1.0) return base;
+// if (exponent == 2.0) return base * base;
+// if (exponent == 3.0) return base * base * base;
+// if (base == 1.0) return 1.0;
+// if (base.isNaN || exponent.isNaN) {
+//    return double.NAN;
+// }
+// if (base != -Infinity && exponent == 0.5) {
+//   if (base == 0.0) return 0.0;
+//   return sqrt(value);
+// }
+// TODO(srdjan): Move into a stub?
+static void InvokeDoublePow(FlowGraphCompiler* compiler,
+                            InvokeMathCFunctionInstr* instr) {
+  ASSERT(instr->recognized_kind() == MethodRecognizer::kMathDoublePow);
+  const intptr_t kInputCount = 2;
+  ASSERT(instr->InputCount() == kInputCount);
+  LocationSummary* locs = instr->locs();
+
+  const VRegister base = locs->in(0).fpu_reg();
+  const VRegister exp = locs->in(1).fpu_reg();
+  const VRegister result = locs->out(0).fpu_reg();
+  const VRegister saved_base = locs->temp(0).fpu_reg();
+  ASSERT((base == result) && (result != saved_base));
+
+  Label skip_call, try_sqrt, check_base, return_nan;
+  __ fmovdd(saved_base, base);
+  __ LoadDImmediate(VTMP, 0.0, PP);
+  __ LoadDImmediate(result, 1.0, PP);
+  // exponent == 0.0 -> return 1.0;
+  __ fcmpd(exp, VTMP);

[zra, 2014/05/08 19:07:57]

__ fcmpdz(exp)

[srdjan, 2014/05/08 22:15:31]

Done.

+  __ b(&check_base, VS);  // NaN -> check base.
+  __ b(&skip_call, EQ);  // exp is 0.0, result is 1.0.
+
+  // exponent == 1.0 ?
+  __ fcmpd(exp, result);
+  Label return_base;
+  __ b(&return_base, EQ);
+
+  // exponent == 2.0 ?
+  __ LoadDImmediate(VTMP, 2.0, PP);
+  __ fcmpd(exp, VTMP);
+  Label return_base_times_2;
+  __ b(&return_base_times_2, EQ);
+
+  // exponent == 3.0 ?
+  __ LoadDImmediate(VTMP, 3.0, PP);
+  __ fcmpd(exp, VTMP);
+  __ b(&check_base, NE);
+
+  // base_times_3.
+  __ fmuld(result, saved_base, saved_base);
+  __ fmuld(result, result, saved_base);
+  __ b(&skip_call);
+
+  __ Bind(&return_base);
+  __ fmovdd(result, saved_base);
+  __ b(&skip_call);
+
+  __ Bind(&return_base_times_2);
+  __ fmuld(result, saved_base, saved_base);
+  __ b(&skip_call);
+
+  __ Bind(&check_base);
+  // Note: 'exp' could be NaN.
+  // base == 1.0 -> return 1.0;
+  __ fcmpd(saved_base, result);
+  __ b(&return_nan, VS);
+  __ b(&skip_call, EQ);  // base is 1.0, result is 1.0.
+
+  __ fcmpd(saved_base, exp);
+  __ b(&try_sqrt, VC);  // // Neither 'exp' nor 'base' is NaN.
+
+  __ Bind(&return_nan);
+  __ LoadDImmediate(result, NAN, PP);
+  __ b(&skip_call);
+
+  Label do_pow, return_zero;
+  __ Bind(&try_sqrt);
+
+  // Before calling pow, check if we could use sqrt instead of pow.
+  __ LoadDImmediate(result, -INFINITY, PP);
+
+  // base == -Infinity -> call pow;
+  __ fcmpd(saved_base, result);
+  __ b(&do_pow, EQ);
+
+  // exponent == 0.5 ?
+  __ LoadDImmediate(result, 0.5, PP);
+  __ fcmpd(exp, result);
+  __ b(&do_pow, NE);
+
+  // base == 0 -> return 0;
+  __ LoadDImmediate(VTMP, 0.0, PP);
+  __ fcmpd(base, VTMP);

[zra, 2014/05/08 19:07:57]

__ fcmpdz(base);

[srdjan, 2014/05/08 22:15:31]

Done.

+  __ b(&return_zero, EQ);
+
+  __ fsqrtd(result, saved_base);
+  __ b(&skip_call);
+
+  __ Bind(&return_zero);
+  __ fmovdd(result, VTMP);
+  __ b(&skip_call);
+
+  __ Bind(&do_pow);
+  __ fmovdd(base, saved_base);  // Restore base.
+
+  __ CallRuntime(instr->TargetFunction(), kInputCount);
+  __ Bind(&skip_call);
+}
+
+
 void InvokeMathCFunctionInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
-  // For pow-function return NaN if exponent is NaN.
-  Label skip_call;
   if (recognized_kind() == MethodRecognizer::kMathDoublePow) {
-    // Pseudo code:
-    // if (exponent == 0.0) return 1.0;
-    // if (base == 1.0) return 1.0;
-    // if (base.isNaN || exponent.isNaN) {
-    //    return double.NAN;
-    // }
-    // if (base != -Infinity && exponent == 0.5) {
-    //   if (base == 0.0) return 0.0;
-    //   return sqrt(value);
-    // }
-    const VRegister base = locs()->in(0).fpu_reg();
-    const VRegister exp = locs()->in(1).fpu_reg();
-    const VRegister result = locs()->out(0).fpu_reg();
-    const VRegister saved_base = locs()->temp(0).fpu_reg();
-    ASSERT((base == result) && (result != saved_base));
-
-    Label try_sqrt, check_base, return_nan;
-    __ fmovdd(saved_base, base);
-    __ LoadDImmediate(VTMP, 0.0, PP);
-    __ LoadDImmediate(result, 1.0, PP);
-    // exponent == 0.0 -> return 1.0;
-    __ fcmpd(exp, VTMP);
-    __ b(&check_base, VS);  // NaN -> check base.
-    __ b(&skip_call, EQ);  // exp is 0.0, result is 1.0.
-
-    __ Bind(&check_base);
-    // Note: 'exp' could be NaN.
-    // base == 1.0 -> return 1.0;
-    __ fcmpd(saved_base, result);
-    __ b(&return_nan, VS);
-    __ b(&skip_call, EQ);  // base is 1.0, result is 1.0.
-
-    __ fcmpd(saved_base, exp);
-    __ b(&try_sqrt, VC);  // // Neither 'exp' nor 'base' is NaN.
-
-    __ Bind(&return_nan);
-    __ LoadDImmediate(result, NAN, PP);
-    __ b(&skip_call);
-
-    Label do_pow, return_zero;
-    __ Bind(&try_sqrt);
-
-    // Before calling pow, check if we could use sqrt instead of pow.
-    __ LoadDImmediate(result, -INFINITY, PP);
-
-    // base == -Infinity -> call pow;
-    __ fcmpd(saved_base, result);
-    __ b(&do_pow, EQ);
-
-    // exponent == 0.5 ?
-    __ LoadDImmediate(result, 0.5, PP);
-    __ fcmpd(exp, result);
-    __ b(&do_pow, NE);
-
-    // base == 0 -> return 0;
-    __ fcmpd(base, VTMP);
-    __ b(&return_zero, EQ);
-
-    __ fsqrtd(result, saved_base);
-    __ b(&skip_call);
-
-    __ Bind(&return_zero);
-    __ fmovdd(result, VTMP);
-    __ b(&skip_call);
-
-    __ Bind(&do_pow);
-    __ fmovdd(base, saved_base);  // Restore base.
+    InvokeDoublePow(compiler, this);
+    return;
   }
-
   __ CallRuntime(TargetFunction(), InputCount());
-  __ Bind(&skip_call);
 }
 
 
 LocationSummary* ExtractNthOutputInstr::MakeLocationSummary(bool opt) const {
   // Only use this instruction in optimized code.
   ASSERT(opt);
   const intptr_t kNumInputs = 1;
   LocationSummary* summary =
       new LocationSummary(kNumInputs, 0, LocationSummary::kNoCall);
   if (representation() == kUnboxedDouble) {
@@ skipping 560 matching lines @@
   compiler->GenerateCall(token_pos(),
                          &label,
                          PcDescriptors::kOther,
                          locs());
   __ Drop(ArgumentCount());  // Discard arguments.
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM64