Fix causal_async_star_stack_contents_test with optimization-counter-threshold=5

Fix causal_async_star_stack_contents_test with optimization-counter-threshold=5

There was an off by one error when generating the causal async stack trace
in the debugger. We were always adding one more frame pass the sentinel frame.
This frame is always _Closure.call which is filtered out by the debugger
already. However when --optimization-counter-threshold=5, _Closure.call was
inlined and we ended up appending the inliner to the stack trace. The
inliner is not filtered out by the debugger so we got an extra frame in
the stack trace.

Fixes #28861

BUG=
R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/6a312d429b3b554b7b2281c7c140bc0dca40bc76

[Cutch, 2017-02-23 01:00:38]

Description was changed from

==========
Fix causal_async_star_stack_contents_test with optimization-counter-threshold=5

There was an off by one error when generating the causal async stack trace
in the debugger. We were always adding one more frame pass the sentinel frame.
This frame is always _Closure.call which is filtered out by the debugger
already. However when --optimization-counter-threshold=5, _Closure.call was
inlined and we ended up appending the inliner to the stack trace. The
inliner is not filtered out by the debugger so we got an extra frame in
the stack trace.

Fixes #28861

BUG=
==========

to

==========
Fix causal_async_star_stack_contents_test with optimization-counter-threshold=5

There was an off by one error when generating the causal async stack trace
in the debugger. We were always adding one more frame pass the sentinel frame.
This frame is always _Closure.call which is filtered out by the debugger
already. However when --optimization-counter-threshold=5, _Closure.call was
inlined and we ended up appending the inliner to the stack trace. The
inliner is not filtered out by the debugger so we got an extra frame in
the stack trace.

Fixes #28861

BUG=
==========

[Cutch, 2017-02-23 01:00:38]

johnmccutchan@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2017-02-23 20:39:50]

lgtm

[Cutch, 2017-02-24 14:58:45]

Description was changed from

==========
Fix causal_async_star_stack_contents_test with optimization-counter-threshold=5

There was an off by one error when generating the causal async stack trace
in the debugger. We were always adding one more frame pass the sentinel frame.
This frame is always _Closure.call which is filtered out by the debugger
already. However when --optimization-counter-threshold=5, _Closure.call was
inlined and we ended up appending the inliner to the stack trace. The
inliner is not filtered out by the debugger so we got an extra frame in
the stack trace.

Fixes #28861

BUG=
==========

to

==========
Fix causal_async_star_stack_contents_test with optimization-counter-threshold=5

There was an off by one error when generating the causal async stack trace
in the debugger. We were always adding one more frame pass the sentinel frame.
This frame is always _Closure.call which is filtered out by the debugger
already. However when --optimization-counter-threshold=5, _Closure.call was
inlined and we ended up appending the inliner to the stack trace. The
inliner is not filtered out by the debugger so we got an extra frame in
the stack trace.

Fixes #28861

BUG=
R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6a312d429b3b554b7b2281c7c140bc0dca40bc76
==========

[Cutch, 2017-02-24 14:58:46]

Committed patchset #2 (id:20001) manually as
6a312d429b3b554b7b2281c7c140bc0dca40bc76 (presubmit successful).