Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: dashboard/dashboard/start_try_job.py

Issue 2707383009: .
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/start_try_job.py
diff --git a/dashboard/dashboard/start_try_job.py b/dashboard/dashboard/start_try_job.py
index 5859ae4952f5715d71c470cc283413d88d63ef70..f66f35a35f0e0b4130b70e29b27185e6e564b9a1 100644
--- a/dashboard/dashboard/start_try_job.py
+++ b/dashboard/dashboard/start_try_job.py
@@ -86,6 +86,7 @@ _NON_TELEMETRY_TEST_COMMANDS = {
'--build_type Release',
],
}
+
_DISABLE_STORY_FILTER = set(_NON_TELEMETRY_TEST_COMMANDS)
_DISABLE_STORY_FILTER.update([
'octane', # Has a single story.
@@ -427,19 +428,25 @@ def GuessBisectBot(master_name, bot_name):
def GuessCommand(
bisect_bot, suite, story_filter=None, rerun_option=None):
"""Returns a command to use in the bisect configuration."""
- if suite in _NON_TELEMETRY_TEST_COMMANDS:
- return _GuessCommandNonTelemetry(suite, bisect_bot)
+ command = _GuessCommandNonTelemetry(suite, bisect_bot)
+ if command:
+ return command
return _GuessCommandTelemetry(suite, bisect_bot, story_filter, rerun_option)
def _GuessCommandNonTelemetry(suite, bisect_bot):
"""Returns a command string to use for non-Telemetry tests."""
- if suite not in _NON_TELEMETRY_TEST_COMMANDS:
- return None
if suite == 'cc_perftests' and bisect_bot.startswith('android'):
return ('src/build/android/test_runner.py '
'gtest --release -s cc_perftests --verbose')
+ if 'resource_sizes' in suite and bisect_bot.startswith('android'):
+ command = _NON_TELEMETRY_TEST_COMMANDS['resource_sizes']
+ return ' '.join(command)
+
+ if suite not in _NON_TELEMETRY_TEST_COMMANDS:
+ return None
+
command = list(_NON_TELEMETRY_TEST_COMMANDS[suite])
if command[0].startswith('./out'):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698