gen_snapshot:

gen_snapshot:

 - Consistently accept hypens or underscores in option names.
 - Replace --snapshot_kind=none with --dependencies-only, since the former is ambiguous as to whether an existing core snapshot needs to be read. Important when using an embedder-specific dart: library.
 - Don't try to canonicalize file paths for the snapshot pieces since this fails if there isn't already a file on disk.

R=asiva@google.com, goderbauer@google.com

Committed: https://github.com/dart-lang/sdk/commit/c4f67280272d84cd79faaa50e14cf5448e098aff

[goderbauer, 2017-02-24 01:26:51]

goderbauer@google.com changed reviewers:
+ goderbauer@google.com

[goderbauer, 2017-02-24 01:26:52]

LGTM

verified on my machine that this now works.

[rmacnak, 2017-02-24 02:06:25]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[siva, 2017-02-27 22:03:37]

lgtm

https://codereview.chromium.org/2707383007/diff/40001/runtime/bin/gen_snapsho...
File runtime/bin/gen_snapshot.cc (right):

https://codereview.chromium.org/2707383007/diff/40001/runtime/bin/gen_snapsho...
runtime/bin/gen_snapshot.cc:212: }
With these changes of accepting '-' and '_' gen_snapshot is not consistent with
command line dart, we should reconcile this in command line dart too.

[rmacnak, 2017-02-27 23:18:00]

https://codereview.chromium.org/2707383007/diff/40001/runtime/bin/gen_snapsho...
File runtime/bin/gen_snapshot.cc (right):

https://codereview.chromium.org/2707383007/diff/40001/runtime/bin/gen_snapsho...
runtime/bin/gen_snapshot.cc:212: }
On 2017/02/27 22:03:37, siva wrote:
> With these changes of accepting '-' and '_' gen_snapshot is not consistent
with
> command line dart, we should reconcile this in command line dart too.

Agreed

[rmacnak, 2017-02-27 23:18:32]

Description was changed from

==========
gen_snapshot:

 - Consistently accept hypens or underscores in option names.
 - Replace --snapshot_kind=none with --dependencies-only, since the former is
ambiguous as to whether an existing core snapshot needs to be read. Important
when using an embedder-specific dart: library.
 - Don't try to canonicalize file paths for the snapshot pieces since this fails
if there isn't already a file on disk.
==========

to

==========
gen_snapshot:

 - Consistently accept hypens or underscores in option names.
 - Replace --snapshot_kind=none with --dependencies-only, since the former is
ambiguous as to whether an existing core snapshot needs to be read. Important
when using an embedder-specific dart: library.
 - Don't try to canonicalize file paths for the snapshot pieces since this fails
if there isn't already a file on disk.

R=asiva@google.com, goderbauer@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c4f67280272d84cd79faaa50e14cf5448e098aff
==========

[rmacnak, 2017-02-27 23:18:35]

Committed patchset #3 (id:40001) manually as
c4f67280272d84cd79faaa50e14cf5448e098aff (presubmit successful).