Network traffic annotation added to sync.

components/sync/engine/net/http_bridge.cc

Index: components/sync/engine/net/http_bridge.cc
diff --git a/components/sync/engine/net/http_bridge.cc b/components/sync/engine/net/http_bridge.cc
index 967cfba1ed4817b97704c480a5afa0a1a1a89415..15ac428ea7b090506ce04c72b151c47e94bbe59b 100644
--- a/components/sync/engine/net/http_bridge.cc
+++ b/components/sync/engine/net/http_bridge.cc
@@ -24,6 +24,7 @@
 #include "net/http/http_network_layer.h"
 #include "net/http/http_request_headers.h"
 #include "net/http/http_response_headers.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/static_http_user_agent_settings.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request_job_factory_impl.h"
@@ -234,8 +235,36 @@ void HttpBridge::MakeAsynchronousPost() {
 
   DCHECK(request_context_getter_.get());
   fetch_state_.start_time = base::Time::Now();
+  net::NetworkTrafficAnnotationTag traffic_annotation =

[msramek, 2017/03/09 12:02:32]

Is it possible toe extract this annotation to one place to avoid repetition?

[Ramin Halavati, 2017/03/09 12:31:20]

We need to define annotations in the same compilation unit as the code that uses
it. There isn't a common class now that the three usages get their URLFetcher
from.

[msramek, 2017/03/09 12:38:05]

Right, I was thinking about creating one - perhaps
components/sync/base/traffic_annotation.h. But this is up to the local code
owners, so if Nicolas is happy, I'm fine.

+      net::DefineNetworkTrafficAnnotation("http_bridge", R"(

[msramek, 2017/03/09 12:02:32]

This sounds quite generic. I would at least prefix all the IDs with "sync_" to
avoid namespace collisions.

[Ramin Halavati, 2017/03/09 12:31:20]

Done.

+        semantics {
+          sender: "Chrome Sync"
+          description:
+            "Chrome Sync synchronizes profile data between Chromium clients "
+            "and Google for a given user account."
+          trigger:
+            "User makes a change to syncable profile data after enabling sync "
+            "on the device."
+          data:
+            "The device and user identifiers, along with any profile data that "
+            "is changing."
+          destination: GOOGLE_OWNED_SERVICE
+        }
+        policy {
+          cookies_allowed: false
+          setting:
+            "Users can disable Chrome Sync by going into the profile settings "
+            "and choosing to Sign Out."
+          policy {
+            SyncDisabled {
+              policy_options {mode: MANDATORY}
+              SyncDisabled: true
+            }
+          }
+        })");
   fetch_state_.url_poster =
-      net::URLFetcher::Create(url_for_request_, net::URLFetcher::POST, this)
+      net::URLFetcher::Create(url_for_request_, net::URLFetcher::POST, this,
+                              traffic_annotation)
           .release();
   if (!bind_to_tracker_callback_.is_null())
     bind_to_tracker_callback_.Run(fetch_state_.url_poster);