Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: components/sync/engine/net/http_bridge.cc

Issue 2707363004: Network traffic annotation added to sync. (Closed)
Patch Set: nits Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/engine/net/http_bridge.cc
diff --git a/components/sync/engine/net/http_bridge.cc b/components/sync/engine/net/http_bridge.cc
index 967cfba1ed4817b97704c480a5afa0a1a1a89415..293ed55f40ea50a3988f7fb46a31ced7b3cc9c86 100644
--- a/components/sync/engine/net/http_bridge.cc
+++ b/components/sync/engine/net/http_bridge.cc
@@ -24,6 +24,7 @@
#include "net/http/http_network_layer.h"
#include "net/http/http_request_headers.h"
#include "net/http/http_response_headers.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
#include "net/url_request/static_http_user_agent_settings.h"
#include "net/url_request/url_fetcher.h"
#include "net/url_request/url_request_job_factory_impl.h"
@@ -234,8 +235,34 @@ void HttpBridge::MakeAsynchronousPost() {
DCHECK(request_context_getter_.get());
fetch_state_.start_time = base::Time::Now();
+ net::NetworkTrafficAnnotationTag traffic_annotation =
+ net::DefineNetworkTrafficAnnotation("http_bridge", R"(
+ semantics {
+ sender: "Chrome Sync"
+ description:
+ "Chrome Sync synchronizes profile data between Chromium clients "
+ "and Google for a given user account."
+ trigger:
+ "User makes a change to syncable profile data after enabling sync "
+ "on the device."
+ data:
+ "The device and user identifiers, along with any profile data that "
+ "is changing."
+ destination: GOOGLE_OWNED_SERVICE
+ }
+ policy {
+ cookies_allowed: false
+ setting: "This feature cannot be disabled by settings."
Nicolas Zea 2017/03/06 17:56:35 Looks like I forgot to specify this string. It sho
Ramin Halavati 2017/03/07 08:53:47 Done.
+ policy {
+ SyncDisabled {
+ policy_options {mode: MANDATORY}
+ SyncDisabled: true
+ }
+ }
+ })");
fetch_state_.url_poster =
- net::URLFetcher::Create(url_for_request_, net::URLFetcher::POST, this)
+ net::URLFetcher::Create(url_for_request_, net::URLFetcher::POST, this,
+ traffic_annotation)
.release();
if (!bind_to_tracker_callback_.is_null())
bind_to_tracker_callback_.Run(fetch_state_.url_poster);
« no previous file with comments | « components/sync/driver/sync_stopped_reporter.cc ('k') | components/sync/engine_impl/attachments/attachment_downloader_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698