Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: components/sync/engine_impl/attachments/attachment_downloader_impl.cc

Issue 2707363004: Network traffic annotation added to sync. (Closed)
Patch Set: policy changed to chrome_policy. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/engine_impl/attachments/attachment_downloader_impl.cc
diff --git a/components/sync/engine_impl/attachments/attachment_downloader_impl.cc b/components/sync/engine_impl/attachments/attachment_downloader_impl.cc
index 73be92992e868792874b43771b3fbb23d54e179d..2651c581ae4deb86006cf7fd5763c29193898956 100644
--- a/components/sync/engine_impl/attachments/attachment_downloader_impl.cc
+++ b/components/sync/engine_impl/attachments/attachment_downloader_impl.cc
@@ -25,6 +25,7 @@
#include "net/http/http_response_headers.h"
#include "net/http/http_status_code.h"
#include "net/http/http_util.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
#include "net/url_request/url_fetcher.h"
#include "net/url_request/url_request_status.h"
@@ -214,8 +215,35 @@ void AttachmentDownloaderImpl::OnURLFetchComplete(
std::unique_ptr<net::URLFetcher> AttachmentDownloaderImpl::CreateFetcher(
const AttachmentUrl& url,
const std::string& access_token) {
- std::unique_ptr<net::URLFetcher> url_fetcher =
- net::URLFetcher::Create(GURL(url), net::URLFetcher::GET, this);
+ net::NetworkTrafficAnnotationTag traffic_annotation =
+ net::DefineNetworkTrafficAnnotation("sync_attachment_downloader", R"(
+ semantics {
+ sender: "Chrome Sync"
+ description:
+ "Chrome Sync synchronizes profile data between Chromium clients "
+ "and Google for a given user account."
+ trigger:
+ "User makes a change to syncable profile data after enabling sync "
+ "on the device."
+ data:
+ "The device and user identifiers, along with any profile data that "
+ "is changing."
+ destination: GOOGLE_OWNED_SERVICE
+ }
+ policy {
+ cookies_allowed: false
+ setting:
+ "Users can disable Chrome Sync by going into the profile settings "
+ "and choosing to Sign Out."
+ chrome_policy {
+ SyncDisabled {
+ policy_options {mode: MANDATORY}
+ SyncDisabled: true
+ }
+ }
+ })");
+ std::unique_ptr<net::URLFetcher> url_fetcher = net::URLFetcher::Create(
+ GURL(url), net::URLFetcher::GET, this, traffic_annotation);
AttachmentUploaderImpl::ConfigureURLFetcherCommon(
url_fetcher.get(), access_token, raw_store_birthday_, model_type_,
url_request_context_getter_.get());
« no previous file with comments | « components/sync/engine/net/http_bridge.cc ('k') | components/sync/engine_impl/attachments/attachment_uploader_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698