Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 27073: Make sure filter buffer is flushed after it fills its output quota... (Closed)

Created:
11 years, 10 months ago by jar (doing other things)
Modified:
9 years, 7 months ago
Reviewers:
huanr
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make sure filter buffer is flushed after it fills its output quota In some cases, when the filter returned but the output buffer was full, the ReadFilteredData code was not "bothering" to call the filter again (because there was no more input data to provide). We now maintain state indicating that the output buffer was filled (last time) and use that to ensure we call the filter(s) again when Read is next called. bug=7985 r=huanr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10244

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M net/url_request/url_request_job.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M net/url_request/url_request_job.cc View 1 2 3 4 5 chunks +23 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jar (doing other things)
11 years, 10 months ago (2009-02-24 00:15:33 UTC) #1
huanr
LGTM http://codereview.chromium.org/27073/diff/1009/6 File net/url_request/url_request_job.cc (right): http://codereview.chromium.org/27073/diff/1009/6#newcode179 Line 179: return true; // EOF indent http://codereview.chromium.org/27073/diff/1009/6#newcode182 Line ...
11 years, 10 months ago (2009-02-24 01:24:26 UTC) #2
jar (doing other things)
11 years, 10 months ago (2009-02-24 01:41:55 UTC) #3
Accidental indent mistakes removed.

http://codereview.chromium.org/27073/diff/1009/6
File net/url_request/url_request_job.cc (right):

http://codereview.chromium.org/27073/diff/1009/6#newcode179
Line 179: return true;  // EOF
On 2009/02/24 01:24:26, huanr wrote:
> indent

Done.

http://codereview.chromium.org/27073/diff/1009/6#newcode182
Line 182: return false;  // IO Pending (or error)
On 2009/02/24 01:24:26, huanr wrote:
> indent

Done.

Powered by Google App Engine
This is Rietveld 408576698