Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Unified Diff: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

Issue 2707263011: Test aria-pressed=mixed on windows (Closed)
Patch Set: git cl try Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
index 090379f4bb2021e8b6acfce208042521867bbc73..e6e0357f862855ea1964acd32d751042a3b816fd 100644
--- a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
@@ -290,22 +290,14 @@ void FillWidgetStates(AXObjectImpl& ax_object,
}
if (role == kToggleButtonRole) {
- if (!ax_object.IsPressed()) {
- properties.addItem(
- CreateProperty(AXWidgetStatesEnum::Pressed,
- CreateValue("false", AXValueTypeEnum::Tristate)));
- } else {
- const AtomicString& pressed_attr =
- ax_object.GetAttribute(HTMLNames::aria_pressedAttr);
- if (EqualIgnoringASCIICase(pressed_attr, "mixed"))
- properties.addItem(
- CreateProperty(AXWidgetStatesEnum::Pressed,
- CreateValue("mixed", AXValueTypeEnum::Tristate)));
- else
- properties.addItem(
- CreateProperty(AXWidgetStatesEnum::Pressed,
- CreateValue("true", AXValueTypeEnum::Tristate)));
- }
+ const AccessibilityButtonState pressed = ax_object.PressedState();
+ const char* pressed_str =
+ pressed == kButtonStateOn
+ ? "true"
+ : (pressed == kButtonStateMixed ? "mixed" : "false");
+ properties.addItem(
+ CreateProperty(AXWidgetStatesEnum::Pressed,
+ CreateValue(pressed_str, AXValueTypeEnum::Tristate)));
}
if (RoleAllowsSelected(role)) {
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h ('k') | third_party/WebKit/Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698