Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2175)

Issue 2707263011: Test aria-pressed=mixed on windows (Closed)

Created:
3 years, 10 months ago by aleventhal
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Test aria-pressed=mixed on windows BUG=726740

Patch Set 1 #

Patch Set 2 : Fix syntax #

Patch Set 3 : Fix syntax #

Patch Set 4 : WIP #

Patch Set 5 : Compile #

Patch Set 6 : WIP #

Patch Set 7 : Greener #

Patch Set 8 : git cl try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+385 lines, -293 lines) Patch
M ash/system/audio/volume_view.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M ash/system/ime_menu/ime_list_view.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/night_light/night_light_toggle_button.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M ash/system/tray/hover_highlight_view.cc View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/automation.idl View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M chrome/renderer/extensions/automation_internal_custom_bindings.cc View 1 2 3 4 5 6 7 1 chunk +20 lines, -10 lines 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 1 2 3 3 chunks +12 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.h View 1 2 3 1 chunk +0 lines, -21 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 1 2 3 2 chunks +2 lines, -44 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_android.cc View 1 2 3 4 5 6 3 chunks +17 lines, -21 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 2 chunks +21 lines, -22 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_com_win.cc View 1 2 3 4 5 6 7 3 chunks +9 lines, -5 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.h View 1 2 3 4 5 6 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.mm View 1 2 3 4 5 6 7 1 chunk +0 lines, -12 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.h View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 2 3 4 2 chunks +9 lines, -13 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 2 3 4 5 6 7 1 chunk +8 lines, -2 lines 0 comments Download
M content/shell/test_runner/web_ax_object_proxy.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/test_runner/web_ax_object_proxy.cc View 1 2 3 4 5 4 chunks +23 lines, -9 lines 0 comments Download
M content/test/data/accessibility/aria/aria-pressed.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-pressed-expected-win.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aom-string-properties.html View 1 2 3 4 5 1 chunk +5 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-checkbox-checked.html View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-checkbox-checked-expected.txt View 1 2 3 4 5 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-checkbox-checked-mixed.html View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/input-mixed.html View 1 2 3 4 5 3 chunks +122 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/option-aria-checked.html View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/AXObject.h View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 2 3 4 5 6 7 1 chunk +8 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 1 2 3 4 1 chunk +8 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 1 2 3 4 5 6 7 2 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/public/web/WebAXEnums.h View 1 2 3 4 5 3 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/public/web/WebAXObject.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ui/accessibility/ax_node_data.cc View 1 2 3 4 2 chunks +17 lines, -3 lines 0 comments Download
M ui/accessibility/ax_node_position_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/ax_tree_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_auralinux.cc View 1 2 3 4 5 6 7 1 chunk +16 lines, -5 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.cc View 1 2 3 4 5 6 7 2 chunks +17 lines, -5 lines 0 comments Download
M ui/views/controls/button/checkbox.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/custom_button.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/button/image_button.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/button/toggle_button.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_item_view.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (25 generated)
aleventhal
The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-24 16:54:09 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707263011/1
3 years, 10 months ago (2017-02-24 16:54:34 UTC) #2
aleventhal
The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-24 18:00:03 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707263011/20001
3 years, 10 months ago (2017-02-24 18:00:23 UTC) #4
aleventhal
The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-24 19:27:36 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707263011/40001
3 years, 10 months ago (2017-02-24 19:28:00 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-24 21:09:18 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 10 months ago (2017-02-24 21:09:19 UTC) #8
aleventhal
The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-25 17:54:08 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707263011/80001
3 years, 7 months ago (2017-05-25 17:54:39 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-25 18:05:42 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/427664)
3 years, 7 months ago (2017-05-25 18:05:43 UTC) #12
aleventhal
The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-25 21:02:29 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707263011/100001
3 years, 7 months ago (2017-05-25 21:03:48 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-25 21:18:27 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/347666)
3 years, 7 months ago (2017-05-25 21:18:29 UTC) #16
aleventhal
The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-25 21:59:45 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707263011/120001
3 years, 7 months ago (2017-05-25 22:00:24 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-25 22:15:29 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/347731) linux_chromium_chromeos_ozone_rel_ng on ...
3 years, 7 months ago (2017-05-25 22:15:31 UTC) #20
aleventhal
The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-26 12:27:10 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707263011/140001
3 years, 7 months ago (2017-05-26 12:27:23 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-26 12:44:07 UTC) #23
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/463822)
3 years, 7 months ago (2017-05-26 12:44:08 UTC) #24
aleventhal
3 years, 7 months ago (2017-05-26 18:58:41 UTC) #25
Description was changed from

==========
Test aria-pressed=mixed on windows

BUG=None
==========

to

==========
Test aria-pressed=mixed on windows

BUG=726740
==========

Powered by Google App Engine
This is Rietveld 408576698