Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2707263009: Store redirecting constructors. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, Vyacheslav Egorov (Google)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -15 lines) Patch
M pkg/front_end/lib/src/fasta/compile_platform.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_loader.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart View 5 chunks +43 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/redirecting_factory_body.dart View 1 chunk +16 lines, -5 lines 0 comments Download
A pkg/front_end/lib/src/fasta/kernel/verifier.dart View 1 chunk +34 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/outline.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/testing/kernel_chain.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/redirecting_constructor.dart.direct.expect View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/redirecting_constructor.dart.outline.expect View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
ahe
3 years, 10 months ago (2017-02-23 20:12:18 UTC) #3
karlklose
LGTM
3 years, 10 months ago (2017-02-24 06:21:53 UTC) #4
ahe
3 years, 10 months ago (2017-02-24 08:04:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f4c669981688f260048eb8af0a0af39ff9a3480d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698