Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp

Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs (Closed)
Patch Set: remove unused checks Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
diff --git a/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp b/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
index 90e01f09addf38b62314f61d5422225943e64a93..6d0a7ec73cdd4b9d0b0875b566c301ddc0aa3b9f 100644
--- a/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
+++ b/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
@@ -477,26 +477,27 @@ void DOMWebSocket::send(DOMArrayBuffer* binaryData,
m_channel->send(*binaryData, 0, binaryData->byteLength());
}
-void DOMWebSocket::send(DOMArrayBufferView* arrayBufferView,
+void DOMWebSocket::send(const NotShared<DOMArrayBufferView>& arrayBufferView,
ExceptionState& exceptionState) {
NETWORK_DVLOG(1) << "WebSocket " << this << " send() Sending ArrayBufferView "
- << arrayBufferView;
- DCHECK(arrayBufferView);
+ << arrayBufferView.view();
+ DCHECK(arrayBufferView.view());
if (m_state == kConnecting) {
setInvalidStateErrorForSendMethod(exceptionState);
return;
}
if (m_state == kClosing || m_state == kClosed) {
- updateBufferedAmountAfterClose(arrayBufferView->byteLength());
+ updateBufferedAmountAfterClose(arrayBufferView.view()->byteLength());
return;
}
recordSendTypeHistogram(WebSocketSendTypeArrayBufferView);
recordSendMessageSizeHistogram(WebSocketSendTypeArrayBufferView,
- arrayBufferView->byteLength());
+ arrayBufferView.view()->byteLength());
DCHECK(m_channel);
- m_bufferedAmount += arrayBufferView->byteLength();
- m_channel->send(*arrayBufferView->buffer(), arrayBufferView->byteOffset(),
- arrayBufferView->byteLength());
+ m_bufferedAmount += arrayBufferView.view()->byteLength();
+ m_channel->send(*arrayBufferView.view()->buffer(),
+ arrayBufferView.view()->byteOffset(),
+ arrayBufferView.view()->byteLength());
}
void DOMWebSocket::send(Blob* binaryData, ExceptionState& exceptionState) {

Powered by Google App Engine
This is Rietveld 408576698