Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp

Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs (Closed)
Patch Set: update comment, add TODO Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
diff --git a/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp b/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
index e8480f512fff0f89833f484a7b48e2bacb9e7ff2..8dde310de9c7f5fad263361e5f49fa8a6f8327bf 100644
--- a/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
+++ b/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
@@ -477,26 +477,27 @@ void DOMWebSocket::send(DOMArrayBuffer* binary_data,
channel_->Send(*binary_data, 0, binary_data->ByteLength());
}
-void DOMWebSocket::send(DOMArrayBufferView* array_buffer_view,
+void DOMWebSocket::send(NotShared<DOMArrayBufferView> array_buffer_view,
ExceptionState& exception_state) {
NETWORK_DVLOG(1) << "WebSocket " << this << " send() Sending ArrayBufferView "
- << array_buffer_view;
+ << array_buffer_view.View();
DCHECK(array_buffer_view);
if (state_ == kConnecting) {
SetInvalidStateErrorForSendMethod(exception_state);
return;
}
if (state_ == kClosing || state_ == kClosed) {
- UpdateBufferedAmountAfterClose(array_buffer_view->byteLength());
+ UpdateBufferedAmountAfterClose(array_buffer_view.View()->byteLength());
return;
}
RecordSendTypeHistogram(kWebSocketSendTypeArrayBufferView);
RecordSendMessageSizeHistogram(kWebSocketSendTypeArrayBufferView,
- array_buffer_view->byteLength());
+ array_buffer_view.View()->byteLength());
DCHECK(channel_);
- buffered_amount_ += array_buffer_view->byteLength();
- channel_->Send(*array_buffer_view->buffer(), array_buffer_view->byteOffset(),
- array_buffer_view->byteLength());
+ buffered_amount_ += array_buffer_view.View()->byteLength();
+ channel_->Send(*array_buffer_view.View()->buffer(),
+ array_buffer_view.View()->byteOffset(),
+ array_buffer_view.View()->byteLength());
}
void DOMWebSocket::send(Blob* binary_data, ExceptionState& exception_state) {
« no previous file with comments | « third_party/WebKit/Source/modules/websockets/DOMWebSocket.h ('k') | third_party/WebKit/Source/modules/webusb/USBDevice.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698