third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp - Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs (Closed)

Patch Set: update comment, add TODO Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp b/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

index e0b5dc13140592109068cf9534f26125e96aea26..bc730d5da4695a4576eab3e36bb6686af10e6221 100644

--- a/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

@@ -131,7 +131,7 @@ void ConvolverHandler::SetBuffer(AudioBuffer* buffer,

RefPtr<AudioBus> buffer_bus =

AudioBus::Create(number_of_channels, buffer_length, false);

for (unsigned i = 0; i < number_of_channels; ++i)

- buffer_bus->SetChannelMemory(i, buffer->getChannelData(i)->Data(),

+ buffer_bus->SetChannelMemory(i, buffer->getChannelData(i).View()->Data(),

buffer_length);

buffer_bus->SetSampleRate(buffer->sampleRate());