third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScopeTest.cpp - Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScopeTest.cpp

Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs (Closed)

Patch Set: update comment, add TODO Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AudioParam.cpp ('k') | third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScopeTest.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScopeTest.cpp b/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScopeTest.cpp

index 0f25c17395d7199509ae5dd1544e220781265cab..6e4e965f8403440990e8e65c0d6f2b24a41f4568 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScopeTest.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScopeTest.cpp

@@ -218,10 +218,12 @@ class AudioWorkletGlobalScopeTest : public ::testing::Test {

AudioBuffer::Create(1, kRenderQuantumFrames, kTestingSampleRate);

AudioBuffer* output_buffer =

AudioBuffer::Create(1, kRenderQuantumFrames, kTestingSampleRate);

- DOMFloat32Array* input_channel_data = input_buffer->getChannelData(0);

+ DOMFloat32Array* input_channel_data =

+ input_buffer->getChannelData(0).View();

float* input_array_data = input_channel_data->Data();

EXPECT_TRUE(input_array_data);

- DOMFloat32Array* output_channel_data = output_buffer->getChannelData(0);

+ DOMFloat32Array* output_channel_data =

+ output_buffer->getChannelData(0).View();

float* output_array_data = output_channel_data->Data();

EXPECT_TRUE(output_array_data);