third_party/WebKit/Source/modules/webaudio/AudioBuffer.h - Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBuffer.h

Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs (Closed)

Patch Set: update comment, add TODO Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBuffer.h

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBuffer.h b/third_party/WebKit/Source/modules/webaudio/AudioBuffer.h

index d946994c57457f5f686ff0b2e4d760c88df63913..510431c039f13bcc18dd2cdc782fa9f6d4a064a1 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBuffer.h

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBuffer.h

@@ -31,6 +31,7 @@

#include "bindings/core/v8/ScriptWrappable.h"

#include "core/dom/DOMTypedArray.h"

+#include "core/dom/NotShared.h"

#include "modules/ModulesExport.h"

#include "wtf/PassRefPtr.h"

#include "wtf/RefPtr.h"

@@ -74,15 +75,20 @@ class MODULES_EXPORT AudioBuffer final : public GarbageCollected<AudioBuffer>,

// Channel data access

unsigned numberOfChannels() const { return channels_.size(); }

- DOMFloat32Array* getChannelData(unsigned channel_index, ExceptionState&);

- DOMFloat32Array* getChannelData(unsigned channel_index);

- void copyFromChannel(DOMFloat32Array*, long channel_number, ExceptionState&);

- void copyFromChannel(DOMFloat32Array*,

+ NotShared<DOMFloat32Array> getChannelData(unsigned channel_index,

+ ExceptionState&);

+ NotShared<DOMFloat32Array> getChannelData(unsigned channel_index);

+ void copyFromChannel(NotShared<DOMFloat32Array>,

+ long channel_number,

+ ExceptionState&);

+ void copyFromChannel(NotShared<DOMFloat32Array>,

long channel_number,

unsigned long start_in_channel,

ExceptionState&);

- void copyToChannel(DOMFloat32Array*, long channel_number, ExceptionState&);

- void copyToChannel(DOMFloat32Array*,

+ void copyToChannel(NotShared<DOMFloat32Array>,

+ long channel_number,

+ ExceptionState&);

+ void copyToChannel(NotShared<DOMFloat32Array>,

long channel_number,

unsigned long start_in_channel,

ExceptionState&);