third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp - Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp

Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs (Closed)

Patch Set: update comment, add TODO Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.h ('k') | third_party/WebKit/Source/modules/presentation/PresentationConnection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp

index 0041bd2430a7ebef9ab6a408f953184a52ea8377..d30cc48bdcf20a60490af8bba5dc3ffa99478af7 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp

@@ -227,10 +227,11 @@ void RTCDataChannel::send(DOMArrayBuffer* data,

}

-void RTCDataChannel::send(DOMArrayBufferView* data,

+void RTCDataChannel::send(NotShared<DOMArrayBufferView> data,

ExceptionState& exception_state) {

- if (!handler_->SendRawData(static_cast<const char*>(data->BaseAddress()),

- data->byteLength())) {

+ if (!handler_->SendRawData(

+ static_cast<const char*>(data.View()->BaseAddress()),

+ data.View()->byteLength())) {

// FIXME: This should not throw an exception but instead forcefully close

// the data channel.

ThrowCouldNotSendDataException(exception_state);