third_party/WebKit/Source/core/fileapi/Blob.cpp - Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fileapi/Blob.cpp

Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs (Closed)

Patch Set: update comment, add TODO Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fileapi/Blob.cpp

diff --git a/third_party/WebKit/Source/core/fileapi/Blob.cpp b/third_party/WebKit/Source/core/fileapi/Blob.cpp

index 3ced27e11e9b4a6e18e8d38b75b4d321545b226e..cc2abf3ed5cdf8e6ca53fc966784b20c3bef7f7e 100644

--- a/third_party/WebKit/Source/core/fileapi/Blob.cpp

+++ b/third_party/WebKit/Source/core/fileapi/Blob.cpp

@@ -132,7 +132,8 @@ void Blob::PopulateBlobData(

DOMArrayBuffer* array_buffer = item.getAsArrayBuffer();

blob_data->AppendBytes(array_buffer->Data(), array_buffer->ByteLength());

} else if (item.isArrayBufferView()) {

- DOMArrayBufferView* array_buffer_view = item.getAsArrayBufferView();

+ DOMArrayBufferView* array_buffer_view =

+ item.getAsArrayBufferView().View();

blob_data->AppendBytes(array_buffer_view->BaseAddress(),

array_buffer_view->byteLength());

} else if (item.isBlob()) {