Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.cpp

Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs (Closed)
Patch Set: add missing tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.cpp b/third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.cpp
index daeda9dc302f8f56025a08c8f042f9bed7551f6c..2fef52b653f418d5f3b0efc6ea42cd653b07adcf 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.cpp
@@ -35,18 +35,18 @@ TestInterface2OrUint8Array TestInterface2OrUint8Array::fromTestInterface2(TestIn
return container;
}
-DOMUint8Array* TestInterface2OrUint8Array::getAsUint8Array() const {
+NotShared<DOMUint8Array> TestInterface2OrUint8Array::getAsUint8Array() const {
DCHECK(isUint8Array());
return m_uint8Array;
}
-void TestInterface2OrUint8Array::setUint8Array(DOMUint8Array* value) {
+void TestInterface2OrUint8Array::setUint8Array(NotShared<DOMUint8Array> value) {
DCHECK(isNull());
- m_uint8Array = value;
+ m_uint8Array = Member<DOMUint8Array>(value.View());
m_type = SpecificTypeUint8Array;
}
-TestInterface2OrUint8Array TestInterface2OrUint8Array::fromUint8Array(DOMUint8Array* value) {
+TestInterface2OrUint8Array TestInterface2OrUint8Array::fromUint8Array(NotShared<DOMUint8Array> value) {
TestInterface2OrUint8Array container;
container.setUint8Array(value);
return container;
@@ -75,7 +75,9 @@ void V8TestInterface2OrUint8Array::toImpl(v8::Isolate* isolate, v8::Local<v8::Va
}
if (v8Value->IsUint8Array()) {
- DOMUint8Array* cppValue = V8Uint8Array::toImpl(v8::Local<v8::Object>::Cast(v8Value));
+ NotShared<DOMUint8Array> cppValue = ToNotShared<NotShared<DOMUint8Array>>(isolate, v8Value, exceptionState);
+ if (exceptionState.HadException())
+ return;
impl.setUint8Array(cppValue);
return;
}

Powered by Google App Engine
This is Rietveld 408576698