third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp - Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs (Closed)

Patch Set: add some layout tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/NotShared.h ('K') | « third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AudioParam.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

index 226288bfe6bd6933253b96a1a5f9dc0818cfc615..4d9ede35485e43a7387e3b315afb216ced20a9be 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

@@ -420,7 +420,7 @@ void AudioBufferSourceHandler::setBuffer(AudioBuffer* buffer,

m_destinationChannels = wrapArrayUnique(new float*[numberOfChannels]);

for (unsigned i = 0; i < numberOfChannels; ++i)

- m_sourceChannels[i] = buffer->getChannelData(i)->data();

+ m_sourceChannels[i] = buffer->getChannelData(i).view()->data();

// If this is a grain (as set by a previous call to start()), validate the

// grain parameters now since it wasn't validated when start was called