third_party/WebKit/Source/modules/crypto/SubtleCrypto.cpp - Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/crypto/SubtleCrypto.cpp

Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs (Closed)

Patch Set: add some layout tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/crypto/SubtleCrypto.cpp

diff --git a/third_party/WebKit/Source/modules/crypto/SubtleCrypto.cpp b/third_party/WebKit/Source/modules/crypto/SubtleCrypto.cpp

index 0214b7adfe4f94329619a4ad10d06e24dfcd7a1d..72a24b1ce8ed2c4ee86f38ce82ef5fd4d8ffb138 100644

--- a/third_party/WebKit/Source/modules/crypto/SubtleCrypto.cpp

+++ b/third_party/WebKit/Source/modules/crypto/SubtleCrypto.cpp

@@ -455,7 +455,7 @@ ScriptPromise SubtleCrypto::importKey(

if (rawKeyData.isArrayBuffer()) {

keyData = copyBytes(rawKeyData.getAsArrayBuffer());

} else if (rawKeyData.isArrayBufferView()) {

- keyData = copyBytes(rawKeyData.getAsArrayBufferView());

+ keyData = copyBytes(rawKeyData.getAsArrayBufferView().view());

} else {

result->completeWithError(

WebCryptoErrorTypeType,