third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp - Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs (Closed)

Patch Set: add some layout tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/NotShared.h ('K') | « third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp ('k') | third_party/WebKit/Source/modules/crypto/Crypto.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

index caf941af0bd3c820cb7e8e44d68258400623dbb6..22d70e545490e66c07a37e485548951fa6e9cfe6 100644

--- a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

@@ -9,6 +9,7 @@

#include "bindings/core/v8/ScriptState.h"

#include "core/css/cssom/CSSURLImageValue.h"

#include "core/css/parser/CSSParser.h"

+#include "core/dom/NotShared.h"

#include "core/frame/ImageBitmap.h"

#include "core/html/HTMLCanvasElement.h"

#include "core/html/HTMLImageElement.h"

@@ -1603,7 +1604,8 @@ ImageData* BaseRenderingContext2D::getImageData(

DOMArrayBuffer* arrayBuffer = DOMArrayBuffer::create(contents);

return ImageData::create(

imageDataRect.size(),

- DOMUint8ClampedArray::create(arrayBuffer, 0, arrayBuffer->byteLength()));

+ NotShared<DOMUint8ClampedArray>(DOMUint8ClampedArray::create(

+ arrayBuffer, 0, arrayBuffer->byteLength())));

}

void BaseRenderingContext2D::putImageData(ImageData* data,