Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp

Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp b/third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp
index 3e3e9e79c715dea4bd1c91717a440aaca9d88abe..81e7d078935d680392135c56d40ef4a57564e33d 100644
--- a/third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp
@@ -262,20 +262,38 @@ double AnalyserNode::smoothingTimeConstant() const {
return analyserHandler().smoothingTimeConstant();
}
-void AnalyserNode::getFloatFrequencyData(DOMFloat32Array* array) {
- analyserHandler().getFloatFrequencyData(array, context()->currentTime());
+void AnalyserNode::getFloatFrequencyData(
+ const MaybeShared<DOMFloat32Array>& array) {
+ // TODO(binji): Throw exception?
+ if (array.isShared()) {
+ analyserHandler().getFloatFrequencyData(array.viewNotShared(),
+ context()->currentTime());
+ }
}
-void AnalyserNode::getByteFrequencyData(DOMUint8Array* array) {
- analyserHandler().getByteFrequencyData(array, context()->currentTime());
+void AnalyserNode::getByteFrequencyData(
+ const MaybeShared<DOMUint8Array>& array) {
+ // TODO(binji): Throw exception?
+ if (array.isShared()) {
+ analyserHandler().getByteFrequencyData(array.viewNotShared(),
+ context()->currentTime());
+ }
}
-void AnalyserNode::getFloatTimeDomainData(DOMFloat32Array* array) {
- analyserHandler().getFloatTimeDomainData(array);
+void AnalyserNode::getFloatTimeDomainData(
+ const MaybeShared<DOMFloat32Array>& array) {
+ // TODO(binji): Throw exception?
+ if (array.isShared()) {
+ analyserHandler().getFloatTimeDomainData(array.viewNotShared());
+ }
}
-void AnalyserNode::getByteTimeDomainData(DOMUint8Array* array) {
- analyserHandler().getByteTimeDomainData(array);
+void AnalyserNode::getByteTimeDomainData(
+ const MaybeShared<DOMUint8Array>& array) {
+ // TODO(binji): Throw exception?
+ if (array.isShared()) {
+ analyserHandler().getByteTimeDomainData(array.viewNotShared());
+ }
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698