[SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs

third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 185 matching lines @@
   return getChannelData(channelIndex);
 }
 
 DOMFloat32Array* AudioBuffer::getChannelData(unsigned channelIndex) {
   if (channelIndex >= m_channels.size())
     return nullptr;
 
   return m_channels[channelIndex].get();
 }
 
-void AudioBuffer::copyFromChannel(DOMFloat32Array* destination,
+void AudioBuffer::copyFromChannel(const NotShared<DOMFloat32Array>& destination,

[haraken, 2017/04/06 08:43:54]

Would it be possible to make NotShared<> be passed by value?

c.f., we're passing RefPtr<> by value.

[binji, 2017/04/09 00:40:02]

Done.

                                   long channelNumber,
                                   ExceptionState& exceptionState) {
   return copyFromChannel(destination, channelNumber, 0, exceptionState);
 }
 
-void AudioBuffer::copyFromChannel(DOMFloat32Array* destination,
+void AudioBuffer::copyFromChannel(const NotShared<DOMFloat32Array>& destination,
                                   long channelNumber,
                                   unsigned long startInChannel,
                                   ExceptionState& exceptionState) {
   if (channelNumber < 0 ||
       channelNumber >= static_cast<long>(m_channels.size())) {
     exceptionState.throwDOMException(
         IndexSizeError, ExceptionMessages::indexOutsideRange(
                             "channelNumber", channelNumber, 0L,
                             ExceptionMessages::InclusiveBound,
                             static_cast<long>(m_channels.size() - 1),
                             ExceptionMessages::InclusiveBound));
     return;
   }
 
   DOMFloat32Array* channelData = m_channels[channelNumber].get();
 
   if (startInChannel >= channelData->length()) {
     exceptionState.throwDOMException(
         IndexSizeError, ExceptionMessages::indexOutsideRange(
                             "startInChannel", startInChannel, 0UL,
                             ExceptionMessages::InclusiveBound,
                             static_cast<unsigned long>(channelData->length()),
                             ExceptionMessages::ExclusiveBound));
 
     return;
   }
 
   unsigned count = channelData->length() - startInChannel;
-  count = std::min(destination->length(), count);
+  count = std::min(destination.view()->length(), count);
 
   const float* src = channelData->data();
-  float* dst = destination->data();
+  float* dst = destination.view()->data();
 
   DCHECK(src);
   DCHECK(dst);
 
   memcpy(dst, src + startInChannel, count * sizeof(*src));
 }
 
-void AudioBuffer::copyToChannel(DOMFloat32Array* source,
+void AudioBuffer::copyToChannel(const NotShared<DOMFloat32Array>& source,
                                 long channelNumber,
                                 ExceptionState& exceptionState) {
   return copyToChannel(source, channelNumber, 0, exceptionState);
 }
 
-void AudioBuffer::copyToChannel(DOMFloat32Array* source,
+void AudioBuffer::copyToChannel(const NotShared<DOMFloat32Array>& source,
                                 long channelNumber,
                                 unsigned long startInChannel,
                                 ExceptionState& exceptionState) {
   if (channelNumber < 0 ||
       channelNumber >= static_cast<long>(m_channels.size())) {
     exceptionState.throwDOMException(
         IndexSizeError, ExceptionMessages::indexOutsideRange(
                             "channelNumber", channelNumber, 0L,
                             ExceptionMessages::InclusiveBound,
                             static_cast<long>(m_channels.size() - 1),
                             ExceptionMessages::InclusiveBound));
     return;
   }
 
   DOMFloat32Array* channelData = m_channels[channelNumber].get();
 
   if (startInChannel >= channelData->length()) {
     exceptionState.throwDOMException(
         IndexSizeError, ExceptionMessages::indexOutsideRange(
                             "startInChannel", startInChannel, 0UL,
                             ExceptionMessages::InclusiveBound,
                             static_cast<unsigned long>(channelData->length()),
                             ExceptionMessages::ExclusiveBound));
 
     return;
   }
 
   unsigned count = channelData->length() - startInChannel;
-  count = std::min(source->length(), count);
+  count = std::min(source.view()->length(), count);
 
-  const float* src = source->data();
+  const float* src = source.view()->data();
   float* dst = channelData->data();
 
   DCHECK(src);
   DCHECK(dst);
 
   memcpy(dst + startInChannel, src, count * sizeof(*dst));
 }
 
 void AudioBuffer::zero() {
   for (unsigned i = 0; i < m_channels.size(); ++i) {
     if (DOMFloat32Array* array = getChannelData(i)) {
       float* data = array->data();
       memset(data, 0, length() * sizeof(*data));
     }
   }
 }
 
 }  // namespace blink