[SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs

third_party/WebKit/Source/bindings/scripts/v8_methods.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 90 matching lines @@
             idl_type.is_explicit_nullable)
 
 
 def method_context(interface, method, is_visible=True):
     arguments = method.arguments
     extended_attributes = method.extended_attributes
     idl_type = method.idl_type
     is_static = method.is_static
     name = method.name
 
+    # TODO(binji): better way to do this?
+    if idl_type.is_explicit_nullable:
+        this_cpp_type = v8_types.cpp_template_type('Nullable',
+                                                   idl_type.cpp_type)
+    elif idl_type.is_array_buffer_view_or_typed_array:
+        this_cpp_type = '%s::TypedArrayType*' % idl_type.cpp_type

[haraken, 2017/04/06 08:43:54]

How is this type used? I cannot find this type in the test results in this CL.

[binji, 2017/04/09 00:40:02]

This happens when a interface method returns an ArrayBufferView, and also might
raise an exception. I added an example of this to the test results.

But I also changed the way this works; now the C++ methods return NotShared<...>
as well, so this conversion isn't required.

+    else:
+        this_cpp_type = idl_type.cpp_type
+
     if is_visible:
         idl_type.add_includes_for_type(extended_attributes)
 
     this_cpp_value = cpp_value(interface, method, len(arguments))
 
     is_call_with_script_arguments = has_extended_attribute_value(method, 'CallWith', 'ScriptArguments')
     if is_call_with_script_arguments:
         includes.update(['bindings/core/v8/ScriptCallStack.h',
                          'core/inspector/ScriptArguments.h'])
     is_call_with_script_state = has_extended_attribute_value(method, 'CallWith', 'ScriptState')
@@ skipping 31 matching lines @@
     if 'LenientThis' in extended_attributes:
         raise Exception('[LenientThis] is not supported for operations.')
 
     argument_contexts = [
         argument_context(interface, method, argument, index, is_visible=is_visible)
         for index, argument in enumerate(arguments)]
 
     return {
         'activity_logging_world_list': v8_utilities.activity_logging_world_list(method),  # [ActivityLogging]
         'arguments': argument_contexts,
-        'cpp_type': (v8_types.cpp_template_type('Nullable', idl_type.cpp_type)
-                     if idl_type.is_explicit_nullable else idl_type.cpp_type),
+        'cpp_type': this_cpp_type,
         'cpp_value': this_cpp_value,
         'cpp_type_initializer': idl_type.cpp_type_initializer,
         'deprecate_as': v8_utilities.deprecate_as(method),  # [DeprecateAs]
         'do_not_test_new_object': 'DoNotTestNewObject' in extended_attributes,
         'exposed_test': v8_utilities.exposed(method, interface),  # [Exposed]
         'has_exception_state':
             is_raises_exception or
             is_check_security_for_receiver or
             any(argument for argument in arguments
                 if (argument.idl_type.name == 'SerializedScriptValue' or
@@ skipping 272 matching lines @@
     return method.idl_type and method.idl_type.name == 'Promise'
 
 IdlOperation.returns_promise = property(method_returns_promise)
 
 
 def argument_conversion_needs_exception_state(method, argument):
     idl_type = argument.idl_type
     return (idl_type.v8_conversion_needs_exception_state or
             argument.is_variadic or
             (method.returns_promise and idl_type.is_string_type))