[SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs

third_party/WebKit/Source/modules/webaudio/AudioParam.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 449 matching lines @@
                                         ExceptionState& exceptionState) {
   warnIfOutsideRange("setTargetAtTime value", target);
   handler().timeline().setTargetAtTime(target, time, timeConstant,
                                        exceptionState);
 
   // Don't update the histogram here.  It's not clear in normal usage if the
   // parameter value will actually reach |target|.
   return this;
 }
 
-AudioParam* AudioParam::setValueCurveAtTime(DOMFloat32Array* curve,
-                                            double time,
-                                            double duration,
-                                            ExceptionState& exceptionState) {
+AudioParam* AudioParam::setValueCurveAtTime(
+    const MaybeShared<DOMFloat32Array>& maybeShared,
+    double time,
+    double duration,
+    ExceptionState& exceptionState) {
+  if (maybeShared.isShared()) {
+    exceptionState.throwTypeError(
+        "The provided curve is backed by a SharedArrayBuffer.");

[Raymond Toy, 2017/03/06 20:06:33]

DBC:  Can we be consistent with the error messages in webaudio about
SharedArrayBuffer?

[binji, 2017/03/14 21:27:35]

Yes, I was trying to be consistent with other error messages in the same file,
but I'd be fine with using something consistent for all SAB error messages too.

+    return nullptr;
+  }
+  DOMFloat32Array* curve = maybeShared.viewNotShared();
+
   float* curveData = curve->data();
   float min = minValue();
   float max = maxValue();
 
   // First, find any non-finite value in the curve and throw an exception if
   // there are any.
   for (unsigned k = 0; k < curve->length(); ++k) {
     float value = curveData[k];
 
     if (!std::isfinite(value)) {
@@ skipping 33 matching lines @@
   return this;
 }
 
 AudioParam* AudioParam::cancelAndHoldAtTime(double startTime,
                                             ExceptionState& exceptionState) {
   handler().timeline().cancelAndHoldAtTime(startTime, exceptionState);
   return this;
 }
 
 }  // namespace blink