build/config/compiler/BUILD.gn - Issue 2707223002: Make --enable-heap-profiling=native "work" on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 2707223002: Make --enable-heap-profiling=native "work" on Windows. (Closed)

Patch Set: Add some TODOs Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index 1f8968670781cf0c6a810bffa6bb47170c0d8979..de110164da14306cf88d3715eb2f7ea500c66a46 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -1396,6 +1396,10 @@ config("default_stack_frames") {

} else if (is_android) {

cflags = [ "-fomit-frame-pointer" ]

}

+ } else if (is_win && enable_profiling) {

+ # common_optimize_on_cflags actually includes /Oy- to enable generation

+ # of frame pointers, but add it here explicitly in case that changes.

+ cflags = [ "/Oy-" ]

}