base/debug/stack_trace.h - Issue 2707223002: Make --enable-heap-profiling=native "work" on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/stack_trace.h

Issue 2707223002: Make --enable-heap-profiling=native "work" on Windows. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/stack_trace.h

diff --git a/base/debug/stack_trace.h b/base/debug/stack_trace.h

index ba1937fe5e6f1702e2b0a177727d99997b3cf3d8..48108bccd5cd17bac17bc154c0010aca5f0a8183 100644

--- a/base/debug/stack_trace.h

+++ b/base/debug/stack_trace.h

@@ -23,13 +23,13 @@ struct _EXCEPTION_POINTERS;

struct _CONTEXT;

#endif

-#if defined(OS_POSIX) && ( \

- defined(__i386__) || defined(__x86_64__) || \

- (defined(__arm__) && !defined(__thumb__)))

+//#if defined(OS_POSIX) && ( \

brettw 2017/02/22 22:03:31 We should clean this up before checking it in.

Wez 2017/02/23 00:12:22 Yup; this was uploaded mainly to unblock Albert -

+// defined(__i386__) || defined(__x86_64__) || \

+// (defined(__arm__) && !defined(__thumb__)))

#define HAVE_TRACE_STACK_FRAME_POINTERS 1

-#else

-#define HAVE_TRACE_STACK_FRAME_POINTERS 0

-#endif

+//#else

+//#define HAVE_TRACE_STACK_FRAME_POINTERS 0

+//#endif

namespace base {

namespace debug {

« no previous file with comments | « no previous file | base/debug/stack_trace.cc » ('j') | no next file with comments »