Make --enable-heap-profiling=native "work" on Windows.

base/debug/stack_trace.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_DEBUG_STACK_TRACE_H_
 #define BASE_DEBUG_STACK_TRACE_H_
 
 #include <stddef.h>
 
 #include <iosfwd>
 #include <string>
 
 #include "base/base_export.h"
 #include "base/macros.h"
 #include "build/build_config.h"
 
 #if defined(OS_POSIX)
 #include <unistd.h>
 #endif
 
 #if defined(OS_WIN)
 struct _EXCEPTION_POINTERS;
 struct _CONTEXT;
 #endif
 
-#if defined(OS_POSIX) && ( \
-    defined(__i386__) || defined(__x86_64__) || \
-    (defined(__arm__) && !defined(__thumb__)))
+// TODO(699863): Clean up HAVE_TRACE_STACK_FRAME_POINTERS.
+#if (defined(OS_POSIX) && (defined(__i386__) || defined(__x86_64__) ||    \
+                           (defined(__arm__) && !defined(__thumb__)))) || \
+    defined(OS_WIN)

[dcheng, 2017/03/13 02:11:21]

Nit: this condition is getting pretty hard to read. Can we break it down to
simplify the conditions, even though that means the HAVE_STACK_FRAME_POINTERS
#define will be redundant?

e.g.

#if defined(OS_POSIX)

#if defined(__i386__) || defined(__x86_64__)
#define HAVE_TRACE_STACK_FRAME_POINTERS 1
#elif defined(__arm__) && !defined(__thumb)
#define HAVE_TRACE_STACK_FRAME_POINTERS 1
#else
#define HAVE_TRACE_STACK_FRAME_POINTERS 0
#endif  // defined(__i386__) || defined(__x86_64__)

#elif defined(OS_WIN)
#define HAVE_TRACE_STACK_FRAME_POINTERS 1
#else
#define HAVE_TRACE_STACK_FRAME_POINTERS 0
#endif  // defined(OS_POSIX)

[Wez, 2017/03/14 05:22:39]

Done, although I'm keeping the TODO because I would actually prefer to make
having frame pointers a POSIX-only flag, since we'll never use them under
Windows anyway.

 #define HAVE_TRACE_STACK_FRAME_POINTERS 1
 #else
 #define HAVE_TRACE_STACK_FRAME_POINTERS 0
 #endif
 
 namespace base {
 namespace debug {
 
 // Enables stack dump to console output on exception and signals.
 // When enabled, the process will quit immediately. This is meant to be used in
@@ skipping 76 matching lines @@
 // but not for release builds (although there are some exceptions).
 //
 // Writes at most |max_depth| frames (instruction pointers) into |out_trace|
 // after skipping |skip_initial| frames. Note that the function itself is not
 // added to the trace so |skip_initial| should be 0 in most cases.
 // Returns number of frames written.
 BASE_EXPORT size_t TraceStackFramePointers(const void** out_trace,
                                            size_t max_depth,
                                            size_t skip_initial);
 
+#if !defined(OS_WIN)
 // Links stack frame |fp| to |parent_fp|, so that during stack unwinding
 // TraceStackFramePointers() visits |parent_fp| after visiting |fp|.
 // Both frame pointers must come from __builtin_frame_address().
 // Destructor restores original linkage of |fp| to avoid corrupting caller's
 // frame register on return.
 //
 // This class can be used to repair broken stack frame chain in cases
 // when execution flow goes into code built without frame pointers:
 //
 // void DoWork() {
@@ skipping 29 matching lines @@
   ScopedStackFrameLinker(void* fp, void* parent_fp);
   ~ScopedStackFrameLinker();
 
  private:
   void* fp_;
   void* parent_fp_;
   void* original_parent_fp_;
 
   DISALLOW_COPY_AND_ASSIGN(ScopedStackFrameLinker);
 };
+#endif  // !defined(OS_WIN)
 
 #endif  // HAVE_TRACE_STACK_FRAME_POINTERS
 
 namespace internal {
 
 #if defined(OS_POSIX) && !defined(OS_ANDROID)
 // POSIX doesn't define any async-signal safe function for converting
 // an integer to ASCII. We'll have to define our own version.
 // itoa_r() converts a (signed) integer to ASCII. It returns "buf", if the
 // conversion was successful or NULL otherwise. It never writes more than "sz"
 // bytes. Output will be truncated as needed, and a NUL character is always
 // appended.
 BASE_EXPORT char *itoa_r(intptr_t i,
                          char *buf,
                          size_t sz,
                          int base,
                          size_t padding);
 #endif  // defined(OS_POSIX) && !defined(OS_ANDROID)
 
 }  // namespace internal
 
 }  // namespace debug
 }  // namespace base
 
 #endif  // BASE_DEBUG_STACK_TRACE_H_