Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 27072003: Remove 2 members from webpreference (Closed)

Created:
7 years, 2 months ago by Julien - ping for review
Modified:
7 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Remove 2 members from webpreference Sticky position and CSS 3 shaders have been changed to be runtime enabled feature and thus piggy-back on top of the experimental web platform features. This change remove the 2 previous preference along with the associated code. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228540

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/web_preferences.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/common/webkit_test_helpers.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/webpreferences.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/common/webpreferences.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Julien - ping for review
Trivial change to remove some useless preference piping to Blink.
7 years, 2 months ago (2013-10-14 13:07:40 UTC) #1
darin (slow to review)
LGTM
7 years, 2 months ago (2013-10-14 17:06:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/27072003/1
7 years, 2 months ago (2013-10-14 17:59:21 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-14 21:41:13 UTC) #4
Message was sent while issue was closed.
Change committed as 228540

Powered by Google App Engine
This is Rietveld 408576698