Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2707183002: Extract FormalParameter tests into FormalParameterParserTestMixin. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract FormalParameter tests into FormalParameterParserTestMixin. So, we can run these tests with analyzer's and fasta's parser. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/11dfac24bd732c1c938714abd66d765123c79118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6458 lines, -5928 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 6 chunks +519 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 13 chunks +5939 lines, -5928 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 10 months ago (2017-02-21 21:29:36 UTC) #1
Paul Berry
lgtm
3 years, 10 months ago (2017-02-21 21:40:26 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 11dfac24bd732c1c938714abd66d765123c79118 (presubmit successful).
3 years, 10 months ago (2017-02-21 21:44:28 UTC) #4
Brian Wilkerson
3 years, 10 months ago (2017-02-21 21:46:44 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698