Add preliminary support for methods to AstBuilder.

Add preliminary support for methods to AstBuilder.

This is just enough support to get tests in TopLevelParserTest_Fasta.
I'll come back and fill in the details later when working specifically
on support for class members.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/67f46c19c1ff1a73df73ee67b5cf4584370beca3

[Paul Berry, 2017-02-21 20:14:15]

paulberry@google.com changed reviewers:
+ ahe@google.com, scheglov@google.com

[scheglov, 2017-02-21 20:17:27]

LGTM

https://codereview.chromium.org/2707163002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2707163002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1022: void endMethod(Token
getOrSet, Token beginToken, Token endToken) {
@override

https://codereview.chromium.org/2707163002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1064: void endMember() {
@override

[Paul Berry, 2017-02-21 20:20:32]

Description was changed from

==========
Add preliminary support for methods to AstBuilder.

This is just enough support to get tests in TopLevelParserTest_Fasta.
I'll come back and fill in the details later when working specifically
on support for class members.
==========

to

==========
Add preliminary support for methods to AstBuilder.

This is just enough support to get tests in TopLevelParserTest_Fasta.
I'll come back and fill in the details later when working specifically
on support for class members.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/67f46c19c1ff1a73df73ee67b5cf4584370beca3
==========

[Paul Berry, 2017-02-21 20:20:33]

Committed patchset #1 (id:1) manually as
67f46c19c1ff1a73df73ee67b5cf4584370beca3 (presubmit successful).

[Paul Berry, 2017-02-21 20:24:03]

https://codereview.chromium.org/2707163002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2707163002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1022: void endMethod(Token
getOrSet, Token beginToken, Token endToken) {
On 2017/02/21 20:17:27, scheglov wrote:
> @override

Done.

https://codereview.chromium.org/2707163002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1064: void endMember() {
On 2017/02/21 20:17:27, scheglov wrote:
> @override

Done.

[ahe, 2017-02-22 11:30:38]

lgtm except for all the unused variables.

https://codereview.chromium.org/2707163002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2707163002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1046: SimpleIdentifier
returnType2 = name;
There's a few hints introduced with this change. Could we agree on keeping the
code free of hints?

[Paul Berry, 2017-02-22 16:37:12]

https://codereview.chromium.org/2707163002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2707163002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1046: SimpleIdentifier
returnType2 = name;
On 2017/02/22 11:30:38, ahe wrote:
> There's a few hints introduced with this change. Could we agree on keeping the
> code free of hints?

Fair enough.  I will follow up with a fix.