chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc - Issue 2707133006: Start ARC and sign in after Chrome OS login

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc

Issue 2707133006: Start ARC and sign in after Chrome OS login (Closed)

Patch Set: test coverage in chrome_launcher_controller_impl_unittest.cc Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc ('K') | « chrome/browser/ui/app_list/arc/arc_app_utils.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc » ('j') | chromeos/chromeos_switches.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc

diff --git a/chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc b/chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc

index f0afccabc750f6a8c70139531014e1f02234967f..cacbc6cc491e77a32f94739016078a0924f2b280 100644

--- a/chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc

+++ b/chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc

@@ -34,11 +34,11 @@ ash::ShelfAction ArcPlaystoreShortcutLauncherItemController::ItemSelected(

ArcAppListPrefs::Get(controller()->profile());

DCHECK(arc_app_prefs);

- const bool arc_was_enabled = arc_session_manager->IsArcPlayStoreEnabled();

+ const bool play_was_enabled = arc_session_manager->IsArcPlayStoreEnabled();

arc_session_manager->SetArcPlayStoreEnabled(true);

// Deferred launcher.

- if (arc_app_prefs->IsRegistered(arc::kPlayStoreAppId) && arc_was_enabled) {

+ if (arc_app_prefs->IsRegistered(arc::kPlayStoreAppId) && play_was_enabled) {

// Known apps can be launched directly or deferred.

arc::LaunchApp(controller()->profile(), arc::kPlayStoreAppId, true);

} else {